Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
other
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
19 Jul 2013 at 15:22 UTC
Updated:
29 Jul 2014 at 22:40 UTC
Jump to comment: Most recent file
This could be quite a big patch and need a few re-rolls so the sooner we can get this in the better.
Meta Issue.
#1916134: Remove module_* deprecated functions
Comments
Comment #1
paravibe commentedI am working on it.
Comment #2
paravibe commentedPlease review.
Comment #3
irek02 commentedI applied and test the patch. All looks good except that there is still one occurrence of module_invoke_all() left in core/includes/form.inc:822 :
$forms = module_invoke_all('forms', $form_id, $args);I didn't find any examples on using Drupal::moduleHandler()->invokeAll('') for forms, so I'm not sure how it should be handled in this case...
Comment #4
paravibe commentedThis patch also replace in core/includes/form.inc, thanks irek02
Comment #5
benjy commentedEverything looks good apart from module_invoke_all() is still referenced in a few comments. Can we fix those up also.
Comment #6
paravibe commentedDone ;)
Comment #8
paravibe commented#6: 2045923-6-replace-module_invoke_all-call.patch queued for re-testing.
Comment #9
benjy commentedI'm not sure if this should be absolute or not, i know namespaces are meant to be absolute in comments but not sure about the global class thing. Ill try find someone else to review.
Comment #10
benjy commentedComment #11
benjy commented@drupalrv discussed in IRC and the rule I'm told is to use absolute so please update the comment to be:
and then we should be good to go!
Comment #12
paravibe commentedOK. Fixed this.
Comment #13
benjy commentedSorry, I spotted a couple more.
This comment should be absolute reference.
This should be absolute also.
Comment #14
paravibe commentedNew one ;)
Comment #15
paravibe commentedComment #16
paravibe commentedPrevious patch no longer applies. So please review new one.
Comment #17
benjy commentedShould be absolute.
Comment #18
paravibe commentedSorry, missed this.
Please, review another one.
Comment #19
benjy commentedLooks good.
Comment #20
alexpottI think we should tackle this is two separate issues - one issue to convert all the prodecural code to use Drupal::module_handler() and another to inject the module handler correctly for all the OO code. A review of the OO code changes will follow...
Comment #21
tim.plunkettComment #22
benjy commentedas per https://drupal.org/node/2045931#comment-7697279 we should be injecting the container in OO code.
Comment #23
tim.plunkettYes, this is RTBC just for the procedural patch. The OO patch is just a starting point for a new issue.
Comment #24
benjy commentedOK sounds good :)
Comment #25
alexpottCommitted the procedural code changes e33ddd1 and pushed to 8.x. Thanks!
Opened #2055371: Replace all module_invoke_all() deprecated function calls in OO code to do the OO code conversion.