The tempstore is being injected into the ViewsUIController, but not being used anywhere. Let's just get it out of there.

CommentFileSizeAuthor
#5 2045709-5.patch2.15 KBfubhy
#2 2045709-2.patch1.99 KBdamiankloip
#2 interdiff-2045709-2.txt794 bytesdamiankloip
vdc.ViewsUIController-remove-tempstore.patch1.95 KBdamiankloip

Comments

aspilicious’s picture

aspilicious commented
Status: Needs review » Needs work

Forgot to remove the @param

damiankloip’s picture

damiankloip commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2045709-2.txt794 bytes
new 2045709-2.patch1.99 KB

ha :) thank you!

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Nice! We should try to move towards not so many really simple patches :)

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

No longer applies.

fubhy’s picture

fubhy commented
Status: Needs work » Needs review
StatusFileSize
new 2045709-5.patch2.15 KB

Re-roll.

damiankloip’s picture

damiankloip commented
Status: Needs review » Reviewed & tested by the community

Back

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Whilst this is an API change if anything is extending ViewsUIController outside of D8 core - well I'd be very surprised.

Committed 972ad35 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.