Allow file_entity to set own upload limit

After testing, even though the message below the add file interface reads with the new limit, I am still able to upload larger files.

* removed whitespace

The filesize validation is skipped for user 1. Therefore use a different user to test the patch.

This works for me.

This should be altered into admin/config/media/file-system instead of adding a new page.

Added the settings to file_entity_form_system_file_system_settings_alter().

This works as well.

Likely need to be re-rolled for #2066459: Move settings to our own page at admin/config/media/file-settings

Moved the settings to the new form.

Works as well.

I've only found a few issues with #10; it looks good otherwise.

1. +++ b/file_entity.admin.inc
   @@ -1070,6 +1070,15 @@ function file_entity_settings_form($form, &$form_state) {
   +    '#weight' => 5,
   

   Now that File entity has its own administration settings form setting a weight is unnecessary.

2. +++ b/file_entity.pages.inc
   @@ -950,9 +950,13 @@ function file_entity_get_upload_validators(array $options = array()) {
   +  elseif (!empty($file_entity_max_filesize) && $file_entity_max_filesize < $max_filesize) {
   +    $validators['file_validate_size'] = array(parse_size($file_entity_max_filesize));
   +  }
   

   If the supplied $options['max_filesize'] pass the if{} statement then the elseif{} will never trigger, allowing other modules to bypass the user defined file size limit.

The new file_entity_max_filesize variable should also be added to the list of variables to delete during uninstall.

#12: add-max-filesize-configuration-option-2045605-12.patch queued for re-testing.

Committed #12 to File entity 7.x-2.x.

http://drupalcode.org/project/file_entity.git/commit/af6c714