Closed (fixed)
Project:
LoginToboggan
Version:
7.x-1.x-dev
Component:
Miscellaneous
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
28 Dec 2007 at 11:33 UTC
Updated:
23 Mar 2008 at 01:01 UTC
Hello.
I enabled "Allow users to login using their e-mail address". On LoginToboggan administration pages is stated: "NOTE: This will disallow users from registering using an e-mail address as their username". I have tried it but user is still able to register using an e-mail address as username. I want to disallow users from doing this and was happy when i found out that it will be done automatically but as I wrote it doesn't work for me and I don't know why.
I am using "Login Toboggan version: 1.83.2.9 , 2007/07/12 01:18:47" and have default configuration except enabled "Allow users to login using their e-mail address".
Thanks a lot.
Comments
Comment #1
hunmonk commentedthis was a documentation error. logintoboggan has never provided that feature, and i have no intent to do so. the only thing the module does is prevent a user from registering with an email address that another user has already used as their email address -- this prevents ambiguity in the login process.
i've also tightened the ambiguity checking by providing the same validation on the user edit form.
the documentation has been corrected, and will appear properly in the next scheduled release of the module.
you'll need to look elsewhere to find the functionality you seek.
Comment #2
gamo commentedOK. Thanks.
Just to explain why I want this functionality - there is still a chance for ambiguity although it is highly improbable.
User 1:
username: A
email address: a[at]b[dot]com
User 2:
username: a[at]b[dot]com
email address: any other email address which is not used in our system so far
If both of them want to login using a[at]b[dot]com, one of them gets error message even though he/she uses correct password.
Comment #3
hunmonk commentedyou are incorrect. please re-read my previous post carefully for the reason why.
Comment #4
gamo commentedSorry, I re-read it twice and can't find the reason why I am incorrect.
Comment #5
hunmonk commentedbasically, in the scenario you outlined in #2, user 2 will never be able to register with the username a[at]b[dot]com -- he'll get a validation error, because LT won't allow a username which already exists as an email address for another user.
that's about as clearly as i can explain it.
Comment #6
gamo commentedIt seems like we are talking about the same thing but can't find agreement. I try to explain it my way.
- I am using default Drupal registration form with 2 input fields - "Username" and "E-mail address"
- In my opinion when we allow user to login using his/her username OR e-mail address we should check 4 rules in registration process to avoid ambiguity:
1. If given username is unique among all registered usernames - this is done, no doubt about it
2. If given email address is unique among all registered email addresses - this is done, no doubt about it
3. If given username is unique among all registered email addresses - this doesn't work for me
4. If given email address is unique among all registered usernames - this doesn't work for me
- In #1 you stated "the only thing the module does is prevent a user from registering with an email address that another user has already used as their email address". This covers rule 2, it works fine, no problem.
- In #5 you stated "LT won't allow a username which already exists as an email address for another user". This covers rule 3, it doesn't work for my LT version and configuration. The reason follows.
- I have done an experiment to simulate rule 3 using scenario from #2:
1. Successfully register user with username "A" and email address "a@b.com".
2. Login as admin and change password for user with username "A" registered in step 1 to "d1".
3. SUCCESSFULLY register user with username "a@b.com" and email address "c@d.com" - no validation error as you stated in #5
4. Login as admin and change password for user with username "a@b.com" registered in step 3 to "d2".
5. Try to login with "A" and password "d1" - works OK
6. Try to login with "c@d.com" and password "d2" - works OK
7. Try to login with "a@b.com" and password "d1" - works OK
8. Try to login with "a@b.com" and password "d2" - failed with message "Sorry, unrecognized username or password. Have you forgotten your password?"
- Same experiment with same result can be done for rule 4.
- Possible solutions:
1. I am using old LT version. My version is 5.x - 1.1.
2. I have bad LT configuration. I am using default configuration except enabled "Allow users to login using their e-mail address".
3. Rule 3 and 4 are not supported in LT and you were incorrect saying "LT won't allow a username which already exists as an email address for another user".
Take care and happy new year..:-)
Comment #7
hunmonk commentedin my testing, rule #3 is upheld, so i don't know what your issue is there. i cannot fix a problem i don't experience.
#4 is worth considering, and should be relatively easy to fix.
reopening to fix #4
Comment #8
hunmonk commentedComment #9
gamo commentedAs for rule #3, I had an old LT version (Login Toboggan version: 1.83.2.9 , 2007/07/12 01:18:47). After upgrading to Login Toboggan version: 1.83.2.30 , 2007/12/29 02:55:18 it works also for me. It was my bad but i didn't know there was a new release...
Comment #10
hunmonk commentedi've spent some more time cleaning up the code, and i believe all cases are fully covered now.
committed changes to 5.x and 6.x
Comment #11
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.