Move aggregator_load_feed_items to the ItemStorageController, retain procedural wrapper

+++ b/core/modules/aggregator/aggregator.pages.incundefined
@@ -103,42 +103,14 @@ function aggregator_page_category_form($form, $form_state, $category) {
  * @return
  *   An array of the feed items.

+++ b/core/modules/aggregator/lib/Drupal/aggregator/ItemStorageControllerInterface.phpundefined
@@ -41,4 +41,28 @@ public function deleteCategories(array $entities);
+   * @return array
+   *   An array of the feed items.

If we're going to bother keeping the wrapper, might as well fix up the @return.

@return \Drupal\aggregator\ItemInterface[]

would be best

+++ b/core/modules/aggregator/lib/Drupal/aggregator/ItemStorageController.phpundefined
@@ -112,4 +112,42 @@ public function saveCategories(Item $item) {
+      case 'sum':
...
+      case 'source':
...
+      case 'category':

Looking at this more closely, we have three different codepaths with three different uses for $data.

Why not write three methods with proper typehinting? They can have a protected helper for the shared pager bit at the bottom.

+++ b/core/modules/aggregator/aggregator.pages.incundefined
@@ -102,43 +102,17 @@ function aggregator_page_category_form($form, $form_state, $category) {
+  Drupal::entityManager()->getStorageController('aggregator_item')->loadFeedItems($type, $data, $limit);

misses the return statement;)

#6 would be awesome

This splits out the methods as per #6 and adds the return statement.

Added related issues

"Failed to write configuration file" Trying again.

#9: 2043581-load-feed-items-9.patch queued for re-testing.

FieldUpgradePathTest fatal. Re-trying.

#9: 2043581-load-feed-items-9.patch queued for re-testing.

Looks great!

Been waiting for this for a while :)

+++ b/core/modules/aggregator/aggregator.pages.incundefined
@@ -102,43 +102,27 @@ function aggregator_page_category_form($form, $form_state, $category) {
+ * @deprecated Use \Drupal\aggregator\ItemStorageController::loadFeedItems()
+ *   instead.

Or loadFeedItemsBySource or loadFeedItemsByCategory... this comment should list the three functions this has been refactored into.

Docs fixes in #17

I assume since it's just doc fixes this can go back to RTBC

#18: 2043581-load-feed-items-18.patch queued for re-testing.

Sorry for checking this that late and i kick it to NW..but methods name dont make much sense to me.
the procedural function name shouldnt not affect the naming.

+++ b/core/modules/aggregator/lib/Drupal/aggregator/ItemStorageControllerInterface.phpundefined
@@ -41,4 +41,42 @@ public function deleteCategories(array $entities);
+  public function loadFeedItems($limit = 20);

i would suggest this being loadAll()
I had to check the docblock to understand what it does and why is different of just load()..

+++ b/core/modules/aggregator/lib/Drupal/aggregator/ItemStorageControllerInterface.phpundefined
@@ -41,4 +41,42 @@ public function deleteCategories(array $entities);
+  public function loadFeedItemsBySource($fid, $limit = 20);

loadByFeed
Source, well, should die sometime. its a "feed" entity not "source"

+++ b/core/modules/aggregator/lib/Drupal/aggregator/ItemStorageControllerInterface.phpundefined
@@ -41,4 +41,42 @@ public function deleteCategories(array $entities);
+  public function loadFeedItemsByCategory($cid, $limit = 20);

loadByCategory

No need to have FeedItems in the method name, its the the Feed Item storage controller

Thanks for the review.

This fixes all of #21.

thank you

Looks great.

Committed 91bd01a and pushed to 8.x. Thanks!

Proposed change notice:

Loading Feed Items has moved to the Storage Controller

The aggregator_load_feed_items() function has been split up and moved to 3 separate methods in \Drupal\aggregator\ItemStorageControllerInterface.

In Drupal 7:

// Loads all feed items.
$items = aggregator_load_feed_items('sum');

// Loads feed items filtered by feed 'source'.  $feed object contains a fid property for the feed ID.
$items = aggregator_load_feed_items('source', $feed);

// Loads feed items filtered by feed category. $category array contains a cid key for the category ID.
$items = aggregator_load_feed_items('category', $category);

In Drupal 8

// Get the ItemStorageController from the dependency injection container.
$storage_controller = Drupal::entityManager()->getStorageController('aggregator_item');

// Loads all feed items.
$storage_controller->loadAll();

// Loads feed items by feed ID ($fid).
$storage_controller->loadByFeed($fid)

// Loads feed items by Category ID ($cid).
$storage_controller->loadByCategory($cid);

Change notice added #2059971: aggregator_feed_items_load() replaced with Aggregator storage controller methods

duplicate

Added change notice