Forward slash in filter aliases in url alias overview doesn't work

Uploading patch

Updating this issue based upon #2357039: Adding "/" in url alias search fatals

Patch is for 7.x, 8.x needs a completely different solution, so setting to active, not needs work.

So something like this by passing the search in the url ?

+++ b/core/modules/path/src/Controller/PathController.php
@@ -55,7 +55,8 @@ public static function create(ContainerInterface $container) {
-  public function adminOverview($keys) {
+  public function adminOverview() {
+    $keys = \Drupal::request()->query->get('search');
     // Add the filter form above the overview table.
     $build['path_admin_filter_form'] = $this->formBuilder()->getForm('Drupal\path\Form\PathFilterForm', $keys);

We should add Request $request to the constructor here I think.

Also passing it along to the form seems pointless if you switch to getting it from the request there? Is that really necessary?

But yes, I think that is the way to go here. I hope we have at least some test coverage of that filtering, then it should be easy to add another condition for some/path.

You can simplify stuff here a bit ... the path controller can get it with the controller arguments and the form can use the passed along keys directly.

Here is also a test to cover the thing.

This looks good to me and I think is the correct fix here. Has test coverage.

Some fix will also be necessary in 7.x, so tagging accordingly. but it can be downgraded to a normal/major bug again, as it doesn't cause an exception like it does in 8.x.

Committed 8afff8c and pushed to 8.0.x. Thanks!

diff --git a/core/modules/path/src/Controller/PathController.php b/core/modules/path/src/Controller/PathController.php
index ef8b1cd..ffabbde 100644
--- a/core/modules/path/src/Controller/PathController.php
+++ b/core/modules/path/src/Controller/PathController.php
@@ -56,6 +56,15 @@ public static function create(ContainerInterface $container) {
     );
   }
 
+  /**
+   * Displays the path administration overview page.
+   *
+   * @param \Symfony\Component\HttpFoundation\Request $request
+   *   The request object.
+   *
+   * @return array
+   *   A render array as expected by drupal_render().
+   */
   public function adminOverview(Request $request) {
     $keys = $request->query->get('search');
     // Add the filter form above the overview table.

Added docblock on commit.

About backport to D7, looks like patch from https://www.drupal.org/node/2418755 do it.

Path #1 appears to work correctly in Drupal 7.

Alternative to using multiple path fragments, what about urlencode() + urldecode()?
But ok for me to use the fragments, to be closer to the D8 solution, and perhaps more BC in D7.

Queued re-test for patch #1.

Patch #1 works for me, but is it okay for the URL to be admin/config/search/path/list/search/terms/here if searching for search/terms/here? What would happen if some custom module creates a page at that URL?

Also, I changed the patch slightly to fix the coding standard for the comment.

Re: my question in #20, searching for the last part in a URL conflict would indeed navigate to that page.

However, I consider that to be out of the scope of this issue, since a module or admin would have to intentionally add such a conflict.

Why are tests failing?

Patch in comment #1 passes tests while patch in #21 fails yet the only difference is formatting for coding standards. Attached is an interdiff.

The tests just needed to be run again.

The D8 fix added to the tests to specifically check a search term including one or more slashes (see #6).

We should do the same for D7.

Added #2418755: Path alias filter by system path as related issue with patch for D7 in comment #1, https://www.drupal.org/project/drupal/issues/2418755#comment-9722205 that has been RTBC, without the patch "it's very hard to find alias which contains few slashes in path."

I added tests and tested them with the fix. Two will fail without the fix, because (1) the slash and anything after it will be removed from the filter input element, and (2) an extra node will show in the search results.

Realized I forgot to delete an alias. Fixed.

The tests look great, thanks!

RTBC + 1

Thanks everyone!

It'd be nice if someone could review #3189420: Underscores in filter aliases in url alias overview treated as wildcards as well.