we need a new display plugin for <opml> though, should be fairly easy to add

Files: 
CommentFileSizeAuthor
#10 aggregator-2039277.patch3.88 KBdawehner
PASSED: [[SimpleTest]]: [MySQL] 60,406 pass(es). View
#8 2039277-aggregator_opml-8.patch7.21 KBgoogletorp
PASSED: [[SimpleTest]]: [MySQL] 58,652 pass(es). View
#8 interdiff.txt1.08 KBgoogletorp
#6 2039277-aggregator_opml-6.patch7.22 KBgoogletorp
FAILED: [[SimpleTest]]: [MySQL] 58,696 pass(es), 0 fail(s), and 149 exception(s). View
#2 2039277-aggregator_opml-2.patch4.78 KBsandhya.m
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 2039277-aggregator_opml-2.patch. Unable to apply patch. See the log in the details link for more information. View

Comments

vijaycs85’s picture

Issue tags: +LONDON_2013_AUGUST
sandhya.m’s picture

Status: Active » Needs review
FileSize
4.78 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 2039277-aggregator_opml-2.patch. Unable to apply patch. See the log in the details link for more information. View

Initial patch...

dawehner’s picture

No views? I haz a sad.

googletorp’s picture

Issue tags: -VDC, -LONDON_2013_AUGUST

#2: 2039277-aggregator_opml-2.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +VDC, +LONDON_2013_AUGUST

The last submitted patch, 2039277-aggregator_opml-2.patch, failed testing.

googletorp’s picture

Status: Needs work » Needs review
FileSize
7.22 KB
FAILED: [[SimpleTest]]: [MySQL] 58,696 pass(es), 0 fail(s), and 149 exception(s). View

Rerolled the patch as is, since #2089635: Convert non-test non-form page callbacks to routes and controllers messed this patch up.

Status: Needs review » Needs work

The last submitted patch, 2039277-aggregator_opml-6.patch, failed testing.

googletorp’s picture

Status: Needs work » Needs review
FileSize
1.08 KB
7.21 KB
PASSED: [[SimpleTest]]: [MySQL] 58,652 pass(es). View

Fixed noticed introduced in the above patchs and make the route name use consistent naming (. notation).

lostkangaroo’s picture

Priority: Normal » Major

This is now blocking #1977608: Update hook_help Aggregator module, which needs to point to this view.

lostkangaroo’s picture

Issue summary: View changes

code..

dawehner’s picture

Title: Convert aggregator/opml to views » Convert aggregator/opml to the new controller style.
Issue summary: View changes
FileSize
3.88 KB
PASSED: [[SimpleTest]]: [MySQL] 60,406 pass(es). View

This patched had a bunch of unrelated changes, probably due to rerolls etc.

Status: Needs review » Needs work

The last submitted patch, 10: aggregator-2039277.patch, failed testing.

dawehner’s picture

Status: Needs work » Needs review

10: aggregator-2039277.patch queued for re-testing.

ParisLiakos’s picture

Status: Needs review » Reviewed & tested by the community

yeah, if i find time to write views plugin for OPML i ll open a new issue..lets get rid of the module_load_include ugliness in there for now

Xano’s picture

10: aggregator-2039277.patch queued for re-testing.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.