Output an unordered list with arbitrary nesting in theme_item_list()

The sitemap feature uses the heirarchy of the menu data to build the lists, not a depth attribute. Which is preferable? In the former case, we need to specify the data structure that the theme function would take (perhaps that output by taxonomy_get_tree?); in the latter, we need to pass depths along as well. When I needed this in a module before, I followed the second approach. The module added:

function theme_hierarchical_list ($items, $depths, $title = NULL)
{
  $output = "";

  if (isset($title)) {
    $output .= "<b>$title</b><br />";
  }

  if (isset($items)) {
    for ($i = 0; $i < count ($items); $i++) {
      $output .= _taxonomy_depth ($depths[$i] + 1, '-&nbsp;');
      $output .= $items[$i] . "<br />";
    }
  }

  return $output;
}

This was before the full transition to CSS; I overrode this in themes to provide a CSS-based solution anyway.

The patch isn't prefect though. There are a few minor coding standard issues that need to be cleaned up, and it has to call theme('item_list') to make sure everything is styled properly. Also I am not sure of the array structure, is that really necessary?

The patch does not apply.

Also, Kjartan pointed out that $item["list"] might not be initialized. I suggest we use $list_type instead. For sake of consistency, $theme["list"] should probably be theme["items"]. Lastly, the patch should be updated to respect Drupal's coding style.

Here is my attempt at this. It will be useful for this issue (and maybe others).

Here is an updated patch.

To the best of my knowledge, this patch respects the coding style and is simple enough. I just tested it out on drupal head and it still applies, with a -42 lines offset though.

+1.

+      if ($children) {

needs to be more explicit. How about count($children) > 0?

New patch following drumm's comment. Since that was the only comment, I'm putting this back to its previous status "ready to be commited".

Committed to HEAD.