Undefined offset: 4 in _menu_translate() (line 777 of includes/menu.inc) - Caused by Webform

I can't reproduce this problem myself. After looking at the other issue, an obvious question is: do you have Diff module installed? Or other modules that display tabs on nodes?

It seems like according to that issue, that using "%" placeholders in hook_menu() triggers this bug. But Webform doesn't use any "%" placeholders to begin with. In comment #73 (#676010-73: diff_menu() issue - undefined offset in includes/menu.inc on line 576 function _menu_translate()) @sun suggested that switching "%" placeholders to named placeholders like "%node" solves the problem. Webform already does this with all its menu entries, so we can't assume the same solution would fix the problem here.

This report is the first time this problem has been reported in the Webform queue. At this point I think it's likely caused by another module. The 4.x version of the module even has the same hook_menu() entries as 3.x, so this seems like it would affect both versions the same.

I have a mirror of this site on localhost, and I wonder if there is a way to identify the source of this issue so that I can help solve.

How we can help?

Start with a fresh installation of Drupal and Webform and see if it has the same problem (it shouldn't), then add the same changes you have on your production site until the problem reoccurs. We can't solve this problem until it's reproducible.

Back to postponed until this can be reproduced from a fresh install of Webform.

@astutonet: Please open a new issue about PHP versions, or post comments to this issue: #2058361: Increase PHP requirement for 7.x-4.x version to PHP 5.3.

Hello, I experienced this problem too, with 7.x-4.0-beta1 after upgrading from alpha. And think I may have found the solution and what's causing the problem. I'll begin by posting the fix, so you wonät have to read my wordy explanation if you don't want to.

quote from https://drupal.org/comment/4120348#comment-4120348:
----
file: webform.module
function webform_menu()

old code:

  $items['node/%webform_menu/webform/emails/%webform_menu_email'] = array(
    'title' => 'Edit e-mail settings',
    'load arguments' => array(1),
    'page arguments' => array('webform_email_edit_form', 1, 4),
    'access callback' => 'node_access',
    'access arguments' => array('update', 1),
    'file' => 'includes/webform.emails.inc',
    'type' => MENU_LOCAL_TASK,
  );
  $items['node/%webform_menu/webform/emails/%webform_menu_email/delete'] = array(
    'title' => 'Delete e-mail settings',
    'load arguments' => array(1),
    'page arguments' => array('webform_email_delete_form', 1, 4),
    'access callback' => 'node_access',
    'access arguments' => array('update', 1),
    'type' => MENU_LOCAL_TASK,
  );

new code:

 $items['node/%webform_menu/webform/emails/%webform_menu_email'] = array(
    'title' => 'Edit e-mail settings',
    'load arguments' => array(1),
    'page arguments' => array('webform_email_edit_form', 1, 4),
    'access callback' => 'node_access',
    'access arguments' => array('update', 1),
    'file' => 'includes/webform.emails.inc',
    'type' => MENU_CALLBACK,
  );
  $items['node/%webform_menu/webform/emails/%webform_menu_email/delete'] = array(
    'title' => 'Delete e-mail settings',
    'load arguments' => array(1),
    'page arguments' => array('webform_email_delete_form', 1, 4),
    'access callback' => 'node_access',
    'access arguments' => array('update', 1),
    'type' => MENU_CALLBACK,
  );

----
/end quote

I spent a few hours reading various threads on drupal.org and then came to the conclusion that the problem does indeed reside in the webform module after reading most posts in this mega long thread: https://drupal.org/node/676010

It's a discussion about a similar problem with the diff module. So I followed the method of doing a "backtrace" from comment #52 in that discussion. And then found that somehow the webform.emails.inc is "sneaking" its way into the menu system where it is not needed and then somehow get's in conflict with menu_translate. Then I started staring blankly at the code for while which didn't help. Then I searched again in the issue queue for webform and to my astonishment this problem seems to have existed before and been fixed. In #19 of this thread https://drupal.org/node/1029498 there's a patch in #22 and the issue is marked as fixed. but somehow the problem has made its way back into the module. I suppose it only occurs under special circumstances for non-english installations otherwise it would have gotten more attention. But the changes in the patch does seem to make a lot of sense and fixed my problem on a "sensitive" production site without having to reinstall or rebuild anything which would have been a great pain since the webform in question has a lot of fields and a lot of conditions.

Thanks for a great module and I hope this fix will make its way into the next beta or rc release.

Solution in #11 confirmed to fix the issue on Drupal 7.24 with webform 7.x-4.0-beta1.

I can also confirm that the solution in #11 fixes the notices with webform 7.x-4.0-beta1. I haven't noticed any side-effects resulting from the change of the type from MENU_LOCAL_TASK to MENU_CALLBACK.

Post #11 worked here as well. I upgraded from 3.x to 4.x while working through this.

Post #11 doesn't seem to work with 7.x-4.0-beta3

Same issue here with webform 7.x-3.20 where my CT has multilangual support (using content translation).

#11 fixxed the problem

Same issue here (just for Webform pages) with Webform 7.x-3.20. It occurred (on a testbed and then the production site) after I:

1. installed and configured Mail System 7.x-2.34 and Mime Mail 7.x-1.0-beta3
2. configured Webform's Format to "HTML"; and, Format Override to "Send all e-mails in the default format."

#11 patch fixed it for me as well -- thanks leanderl ! If you have follow-up questions, please feel free to contact me at ljr@unc.edu . And, of course, thanks so much for such an excellent module!

#11 worked for me too on RC3 after clearing caches
there is a new menu entry webform_menu_email/clone though between webform_menu_email and webform_menu_email/delete.
I personally applied the modification (MENU_CALLBACK) to it aswell. No error so far but haven't fully tested.

I can confirm that #11 worked for me - ONLY after I cleared cache.

Notice: Undefined offset: 4 in _menu_translate() (line 777 of ... includes\menu.inc).
Notice: Undefined offset: 5 in _menu_translate() (line 777 of ... includes\menu.inc).

This happens also without Webform. Fresh minimal installation of Drupal 7.28 plus OG and some other modules but no Webform.

#11 worked for me too, problem exist only on webform pages!!!

@quicksketch -- Just looking at this, it does seem that Edit, Clone and Delete, which are links generated in the table of e-mail settings, should in fact be MENU_CALLBACKS. These items should not generate any actual menu entries (menu item, tab, or local action). In my experience this is normally harmless, but there must be some situation where the menu module is not expecting to see what is essentially a tab within a tab within a tab.

node/%webform_menu/ -> this is the node
webform/ -> This is the Webform tab
emails/ -> This is the secondary E-mail menu (not shown as a tab in most themes)
%webform_menu_email -> Oh dear, I'm out of stuff to show this menu entry.

When I get a chance, I'll test and commit this change, unless you see a reason to the contrary.

Attached patch removes titles (not used) and changes type to MENU_CALLBACK for Edit, Clone, and Delete e-mail settings commands.

Pushed to 7.x-4.x, 7.x-3.x, and 8.x-4.x. I did not change the 6.x branch because I was not sure anyone had the issue and I think the menus are a bit different in D6. If anyone feels that D6 needs to be changed, please make the changes from the patch, test, and re-open, changing the version to 6.x

@leanderl - Darn it. Forgot to attribute the solution to you in the commits. My sincere apologies for the oversight.

I can also confirm that the solution in #24 fixes the notices with webform 7.x-4.8.

Thanks.

I too can confirm that this solution works on webform 4.8

Thanks a lot.

Just so everyone understands, this patch is in 4.8. If you're using 4.8, you're all set.

Hi Dan,

Thanks for all the help and all the fixes you included in the latest release.

I just updated to 4.8 this morning and had to use this patch. Am I missing something?

Dan,
I think you are wrong because I had got release 4.8 and it had not got this patch.

Ah. I see know. This patch broke the breadcrumbs and node tabs. #2472643: Breadcrumb and node tabs missing from e-mail add, edit, clone, and delete.

So we are back to square one. We need a solution other than the patch, which breaks the breadcrumbs and node tabs.

Even though this issue is for the diff_menu module, it started out as a core menu issue:
#676010: diff_menu() issue - undefined offset in includes/menu.inc on line 576 function _menu_translate()

It is not clear to me why in some circumstances _menu_translate is being called for a path with $map having fewer elements that $router_item['number_parts']. It's like its trying to match a router item node/NID/webform/email/EMAIL_ID when the actual math is just node/NID/webform/email.

Let's start by some clear instructions for how to reproduce this. What are the MINIMAL modules needed, and what path to I visit to exhibit the problem.

The patch above is NOT the right fix.

Also #1029498: Undefined offset errors caused by Webform menu entries. The last comment by sun is particularly interesting. Alas, we have already implement menu loader functions (webform_menu_load and webform_menu_email_load in this case), so I don't see how his comment at the end help.

I really need to be able to reproduce this. I suspect some other module is adding menu items that is causing the problem.

Let me be more blunt.

If you can reproduce this bug, take the patch back out and make instructions to reproduce it. Otherwise, it will never get fixed and if you keep applying the patch, you will never have correct breadcrumbs and tabs.

I believe it is a conflict with another module.

I have an unpatched install of:
Drupal 7.36
Webform 7.x-4.8
Webform Confirm Email 7.x-2.3
Webform Rules 7.x-1.6

IF
i choose "Send all e-mails in the default format" for the following option
(in:: Home » Administration » Configuration » Content authoring » Webform settings)
Format override
( ) Per-webform configuration of e-mail format
(X) Send all e-mails in the default format
Force all webform e-mails to be sent in the default format.

THEN
i get the following bunch of errors on the edit page and on the webform itself (also for anonymous users):

Notice: Undefined offset: 4 in _menu_translate() (line 779 of /home/tamera/www/www/includes/menu.inc).
Notice: Undefined offset: 4 in _menu_translate() (line 779 of /home/tamera/www/www/includes/menu.inc).
Notice: Undefined offset: 4 in _menu_translate() (line 785 of /home/tamera/www/www/includes/menu.inc).
Notice: Undefined offset: 4 in _menu_translate() (line 779 of /home/tamera/www/www/includes/menu.inc).
Notice: Undefined offset: 4 in _menu_translate() (line 785 of /home/tamera/www/www/includes/menu.inc).

Hope this helps...

@adminterranova -- can you reproduce this without confirm e-mail? Without Webform rules?

I'm away for a few days, but I'll see if I have internet access and time.

Reproduced and fixed. Don't need webform_rules or rules. The "format override" is the important key to reproducing the issue.

Will post patch and commit fix within a day or two.

Committed to 7.x-4.x and 8.x

I noticed this error after installing the Flag module. I can confirm the patch is already in the Webform module.

Seems like Flag is having a similar issue. I'm adding a link to that thread so there can be some cross assistance.

https://www.drupal.org/node/2464867

Same as comment #21 above, we also do not have WebForm installed, and are getting this error:

[X] Notice: Undefined offset: 4 in _menu_translate() (line 787 of /var/www/html/projectname/includes/menu.inc).

It happens when I click on the Structure link from the /admin/structure/blocks page in the breadcrumbs.

Thanks DanChadwick for the patch. This fixes the notice.

Hi, I hoped to find a solution for my problem. After updating webform 7.4.12 to 7.4.14 warning restarted to be displayed. I already tried the current dev + downgrading to 7.4.12 - but in any case I see now the following warnings:

    Notice: Undefined offset: 5 in _menu_translate() (line 787 of /Users/kai/Documents/webseiten/tui-acquia-dev-git/docroot/includes/menu.inc).
    Notice: Undefined offset: 7 in _menu_translate() (line 787 of /Users/kai/Documents/webseiten/tui-acquia-dev-git/docroot/includes/menu.inc).
    Notice: Undefined offset: 8 in _menu_translate() (line 787 of /Users/kai/Documents/webseiten/tui-acquia-dev-git/docroot/includes/menu.inc).

Any help / idea on how to debug this?

#update: I opened a new issue for this: https://www.drupal.org/node/2861076 #