Problem

In #2003892: Convert date formats to config entities, the date formats have been moved from system.date.yml to their own config entity files. We need to cover this in config schema.

1. Remove date format related pieces from system.date.yml config.
2. Introduce config schema for date formats.

CommentFileSizeAuthor
#7 2038285-config-schema-date-format-7.patch2.76 KBgábor hojtsy
#5 2038285-config-schema-date-format-5.patch2.14 KBvijaycs85
#5 2038285-diff-2-5.txt499 bytesvijaycs85
#2 2038385-config-schema-date-format-2.patch2.15 KBvijaycs85
#2 2038385-diff-1-2.txt1.01 KBvijaycs85
#2 system.date_format.long_.png49.21 KBvijaycs85
#3 system.date_format.long-3.png36.76 KBvijaycs85
#3 2038285-config-schema-date-format-3.patch2.06 KBvijaycs85
#3 2038285-diff-2-3.txt781 bytesvijaycs85
#1 date-format-schema.patch2.04 KBgábor hojtsy

Comments

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Active » Needs review
Issue tags: +sprint
StatusFileSize
new date-format-schema.patch2.04 KB

Here is a quick first pass. I did not check if it works or not :) I propose we do not keep the separate data type, since we don't need to reuse it elsewhere and now the date format itself is a config entity, so it is a data type in itself.

vijaycs85’s picture

vijaycs85
Location London, UK
commented
StatusFileSize
new system.date_format.long_.png49.21 KB
new 2038385-diff-1-2.txt1.01 KB
new 2038385-config-schema-date-format-2.patch2.15 KB

Updating with few label changes and config_inspector screenshot.

vijaycs85’s picture

vijaycs85
Location London, UK
commented
StatusFileSize
new 2038285-diff-2-3.txt781 bytes
new 2038285-config-schema-date-format-3.patch2.06 KB
new system.date_format.long-3.png36.76 KB

After discussed with @Gábor Hojtsy on IRC and looked at DateFormat.php, found that D8 supports only two patterns DrupalDateTime::PHP and DrupalDateTime::INTL and both will be string. So updating pattern to work for both without any date_format.pattern.php or date_format.pattern.intl

Ignore this patch. patch in #2 is the correct one.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Needs work

Reviewed #2

+++ b/core/modules/system/config/schema/system.schema.ymlundefined
@@ -90,12 +90,45 @@ system.date:
+      label: 'Select localizations'

Can we make this "Languages" on the user interface and here too? Its not localizations as all...

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Status: Needs work » Needs review
StatusFileSize
new 2038285-diff-2-5.txt499 bytes
new 2038285-config-schema-date-format-5.patch2.14 KB

Updated label in schema here and created new issue for form label update: #2040123: Update 'Select localizations' label in DateFormat to 'Languages'

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Reviewed & tested by the community

Yay! Looks good!

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue tags: +blocker
StatusFileSize
new 2038285-config-schema-date-format-7.patch2.76 KB

Merged with #2040123: Update 'Select localizations' label in DateFormat to 'Languages' since it uses the same labeling and the two committed separately may have a problem of introducing UI inconsistencies. Still RTBC since that was also RTBC.

Also marking a blocker of config translation (#1952394: Add configuration translation user interface module in core) because this cannot yet be integrated with that until the schemas are fixed.

vijaycs85’s picture

vijaycs85
Location London, UK
commented

Looks good to me.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 92f74b2 and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue tags: -sprint

Removing sprint tag.