Update configuration schema for date formats as entities [#2038285]

Problem

In #2003892: Convert date formats to config entities, the date formats have been moved from system.date.yml to their own config entity files. We need to cover this in config schema.

1. Remove date format related pieces from system.date.yml config.
2. Introduce config schema for date formats.

Comment	File	Size	Author
#7	2038285-config-schema-date-format-7.patch	2.76 KB	Gábor Hojtsy
#7
#5	2038285-config-schema-date-format-5.patch	2.14 KB	vijaycs85
#5
#5	2038285-diff-2-5.txt	499 bytes	vijaycs85
#2	2038385-config-schema-date-format-2.patch	2.15 KB	vijaycs85
#2
#2	2038385-diff-1-2.txt	1.01 KB	vijaycs85
#2	system.date_format.long_.png	49.21 KB	vijaycs85
#3	system.date_format.long-3.png	36.76 KB	vijaycs85
#3	2038285-config-schema-date-format-3.patch	2.06 KB	vijaycs85
#3
#3	2038285-diff-2-3.txt	781 bytes	vijaycs85
#1	date-format-schema.patch	2.04 KB	Gábor Hojtsy
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Gábor Hojtsy

he/him

Hungarian

Hungary

CreditAttribution: Gábor Hojtsy commented 9 July 2013 at 19:58

Status:	Active	» Needs review
Issue tags:		+sprint

File	Size
date-format-schema.patch	2.04 KB

Here is a quick first pass. I did not check if it works or not :) I propose we do not keep the separate data type, since we don't need to reuse it elsewhere and now the date format itself is a config entity, so it is a data type in itself.

Comment #2

vijaycs85

London, UK

CreditAttribution: vijaycs85 commented 11 July 2013 at 18:34

File	Size
system.date_format.long_.png	49.21 KB
2038385-diff-1-2.txt	1.01 KB
2038385-config-schema-date-format-2.patch	2.15 KB

Updating with few label changes and config_inspector screenshot.

Comment #3

vijaycs85

London, UK

CreditAttribution: vijaycs85 commented 11 July 2013 at 18:33

File	Size
2038285-diff-2-3.txt	781 bytes
2038285-config-schema-date-format-3.patch	2.06 KB

system.date_format.long-3.png	36.76 KB

After discussed with @Gábor Hojtsy on IRC and looked at DateFormat.php, found that D8 supports only two patterns DrupalDateTime::PHP and DrupalDateTime::INTL and both will be string. So updating pattern to work for both without any date_format.pattern.php or date_format.pattern.intl

Ignore this patch. patch in #2 is the correct one.

Comment #4

Gábor Hojtsy

he/him

Hungarian

Hungary

CreditAttribution: Gábor Hojtsy commented 11 July 2013 at 18:36

Status:

Needs review

» Needs work

Reviewed #2

+++ b/core/modules/system/config/schema/system.schema.ymlundefined
@@ -90,12 +90,45 @@ system.date:
+      label: 'Select localizations'

Can we make this "Languages" on the user interface and here too? Its not localizations as all...

Comment #5

vijaycs85

London, UK

CreditAttribution: vijaycs85 commented 11 July 2013 at 18:48

Status:

Needs work

» Needs review

File	Size
2038285-diff-2-5.txt	499 bytes
2038285-config-schema-date-format-5.patch	2.14 KB

Updated label in schema here and created new issue for form label update: #2040123: Update 'Select localizations' label in DateFormat to 'Languages'

Comment #6

Gábor Hojtsy

he/him

Hungarian

Hungary

CreditAttribution: Gábor Hojtsy commented 11 July 2013 at 18:50

Status:

Needs review

» Reviewed & tested by the community

Yay! Looks good!

Comment #7

Gábor Hojtsy

he/him

Hungarian

Hungary

CreditAttribution: Gábor Hojtsy commented 16 July 2013 at 16:22

Issue tags:

+blocker

File	Size
2038285-config-schema-date-format-7.patch	2.76 KB

Merged with #2040123: Update 'Select localizations' label in DateFormat to 'Languages' since it uses the same labeling and the two committed separately may have a problem of introducing UI inconsistencies. Still RTBC since that was also RTBC.

Also marking a blocker of config translation (#1952394: Add configuration translation user interface module in core) because this cannot yet be integrated with that until the schemas are fixed.