I'm opening this as a support issue, but it might be considered a bug; feel free to change it.

While the module only shows FAQs if they are of the "faq" type, the Categories block (delta=0) shows terms from all vocabularies that apply to faq nodes. For example, I'm using the Glossary module to highlight terms in content. That module requires that "FAQ" be listed in its vocabulary. That adds all the Glossary terms to the FAQ Terms block, even though they are not FAQ categories.

CommentFileSizeAuthor
#2 faq_203817.patch1.56 KBstella

Comments

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

I also see this problem in the Weight page.

stella’s picture

stella commented
StatusFileSize
new faq_203817.patch1.56 KB

I don't think you need to configure the Glossary vocabulary for faq nodes in order for it to work. However, I have attached a patch that should overcome this problem in case people do associate terms with the FAQ node type without actually configuring the nodes themselves with the terms. I think this might also prevent the displaying of valid FAQ terms which have no associated nodes.

Cheers,
Stella

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

Ha! It's always great to learn something about your own module by posting an issue for someone else! I wonder when I "fixed" this? So now you've given me two more documentation tasks to do - thanks. :(

The patch should be effective. And actually, I don't think FAQ has ever shown categories for which there were no nodes.

However, there has been stuff written about taxonomy's "count_nodes" having very poor performance. But it is easy to use and "protected" as part of core. I no longer use it if I can avoid it. I just do a COUNT query on the term_nodes table; this is much faster.

stella’s picture

stella commented
Status: Active » Fixed
Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

stella’s picture

stella commented

Released in FAQ 5.x-2.7 and FAQ 6.x-1.3.

Cheers,
Stella