Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.New icons "UTF icons :-)" are really great, thanks. But please, move "Has suggestion" and "Show detailed information" back left for two reasons:
1) You have to move your eyes too much to see if this string has a suggestion
2) It's really far from "Show detail" to "Approve suggestion" by mouse.
This really slows me (and few others) down.
New icon "edit" on the left also doesn't actual situation, because it means "copy to edit", not "edit". (and it's missing a title).
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | l10n_left.patch | 4.23 KB | meba |
| #9 | l10n_approved.png | 5.17 KB | meba |
| #7 | l10n_nosuggestion.png | 5.07 KB | meba |
| #6 | l10n_left.patch | 3.59 KB | meba |
| #6 | l10n_left_right.png | 30.01 KB | meba |
Comments
Comment #1
psicomante commentedI tried to put these two icons on the left, but i think it's more clean this setting
Comment #2
psicomante commentedModified message.
Comment #3
meba commentedI think it's "nicer" to have them on the right, but so unusable (in the means of usability)...
Second picture shows one problem with simply moving icons to the left. After suggestion is approved, text "Suggestion approved." moves "Edit" icon, which is a little bit inconvenient
Comment #4
gábor hojtsymeba:
1. The left moved buttons look quite good on your shots, BUT they definitely are not aligned with the edit button on the translation which makes that part of the UI unbalanced, right? (Moving that suggestion approved message to eg. the right corner of the fieldset is easy :)
2. Also, if you have three strings with one having suggestions, the edit and detail buttons are positioned differently on each. With these buttons in the right corner, this is not a problem. Also, if you remove the last suggestion, the suggestion marker disappears, which makes the buttons jump. (We should also remove the marker, when you approve one suggestion, that's also easy). Well we can always include the suggestion button, but make it gray, so that it does not make the buttons jump. What about this? (It still leaves (1) open).
3. Also, while we are on button naming, how about usability of the edit buttons at large. When you have a translation, how evident it is that you would click the edit button before the translation and not on the source text to edit the translation? I think it is not evident. Any ideas here?
Comment #5
meba commentedad 1) my mockup is just float:right -> float: left. Can be changed easily
ad 2) Your idea is cool. Or we can always include "blank" icon, just to insert a padding?
ad 3) I didn't even think about clicking the source text to edit a translation. So it is OK I think. But I think that "edit" button is inappropriate for "copy to form".
Comment #6
meba commentedLet's roll up and move on :-)
Attaching a patch and a screenshot:
1) Buttons are on the left
2) Message is on the right
3) No suggestion means gray icon
Comment #7
meba commentedOne more screenshot with gray icon (the last one is missing it)
Comment #8
gábor hojtsyLooking at #6, it looks like the "suggestion approved" text might get too close to the original string. It only has a 0.3em margin on the right. Maybe we should mark this text with some other style too?
About the "edit" button title, we can look up an abstract icon for this too :) or use "copy". Would that be better? (Technically we never edit neither the source string, neither the suggestion, we always copy it over to the edit box and submit a new suggestion/translation).
Comment #9
meba commentedLike this? (See a screenshot)
Comment #10
gábor hojtsyLooks good to me.
Comment #11
meba commentedOK, rolling again
Comment #12
gábor hojtsyThanks, committed this one, but modified slightly. Reused the disabled style for the has-no-suggestion style, so that we don't repeat ourselfs too much in the CSS. Thanks!
Comment #13
(not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.