Uninitialized string offset: 0 in webform_email_edit_form() [#2038139]

This has shown up after I have selected an options list in Component value selectbox in E-mail settings and pressed Add.

Notice: Uninitialized string offset: 0 in webform_email_edit_form() (Zeile 267 von sites/all/modules/webform/includes/webform.emails.inc).

#default_value is line 267:

        foreach ($options as $key => $label) {
          $form[$field . '_mapping'][$cid][$key] = array(
            '#type' => 'textfield',
            '#title' => $label,
            '#default_value' => is_numeric($email[$field]) && $email[$field] == $cid && isset($email['extra'][$field . '_mapping'][$key]) ? $email['extra'][$field . '_mapping'][$key] : '',
            '#attributes' => array('placeholder' => t('email@example.com')),
          );
        }

Comment	File	Size	Author
#10	2038139-10-rollback-unrelated-changes.patch	2.42 KB	fenstrat
#9	webform-2038139-8.patch	681 bytes	ParisLiakos
#5	Fix-php-notices-on-email-options-form-2038139-5.patch	910 bytes	marcoscano

Comments

Comment #1

quicksketch

he/him

commented 9 July 2013 at 19:33

Thanks, this issue may be related to #2028949: Warning: Invalid argument supplied for foreach() in webform_submission_send_mail(). I'll see if I can reproduce the problem.

I tried to reproduce it again one minute later, but failed. I cannot remember what I've done in what order. I haven't had the patch from #2038139: Uninitialized string offset: 0 in webform_email_edit_form() applied.

Comment #3

quicksketch

he/him

commented 9 July 2013 at 21:02

Status:

Active

» Postponed (maintainer needs more info)

Hm, I can't reproduce it either. Let me know if you can figure out way to reproduce this error.

Comment #3.0

quicksketch

he/him

commented 9 July 2013 at 21:02

Issue summary:

View changes

Updated issue summary.

Comment #4

marcoscano

Portuguese, Brazil

Barcelona, Spain

commented 18 November 2013 at 10:30

Issue summary:	View changes
Status:	Postponed (maintainer needs more info)	» Active

Also happened for me, but only the first time the form was built.
Version 7.x-4.0-beta1, core 7.23
- Created a select element in the form, with different pairs "key|label"
- When was going to create the email mapping using the element created previously, the notices appeared - one for each pair key|label, but all of them with the same message:
Notice: Uninitialized string offset: 0 in webform_email_edit_form() (line 267 of /var/www/html/sites/all/modules/webform/includes/webform.emails.inc).

The mapping values are stored correctly, and the following builds of the form are executed correctly, i.e. the notices are not shown.

Don't know if this information helps to investigate the issue further, marking it as active just in case

Also marked #2134355: Error when setting an email address for a webform as duplicate of this one

Comment #5

marcoscano

Portuguese, Brazil

Barcelona, Spain

commented 18 November 2013 at 14:19

Status:

Active

» Needs review

Status	File	Size
new	Fix-php-notices-on-email-options-form-2038139-5.patch	910 bytes

It happened again with another form, so I didn't save it (to avoid loosing track of the bug) and could investigate it a bit further. Apparently the problem comes from

isset($email['extra'][$field . '_mapping'][$key])

once the $email['extra'] is an empty string at that point and the [] is evaluated before the isset().

Added an additional is_array() to check that before the array evaluation. With this, for me the notices are gone.

Patch attached