Can't imagine a use-case for showing the Olark widget on admin pages. Plus, it causes JavaScript errors when trying to configure/add panes to a mini panel (and maybe when adding panes to normal panels, too, not sure).

Patch forthcoming.

CommentFileSizeAuthor
#8 don_t_show_olark_widget-2035919-8.patch2.31 KBjoelpittet
#4 interdiff.txt1.32 KBjoelpittet
#4 don_t_show_olark_widget-2035919-4.patch2.56 KBjoelpittet
#1 olark_2035919-1_no-widget-on-admin-pages.patch1.69 KBadamdicarlo

Comments

adamdicarlo’s picture

adamdicarlo commented
Status: Active » Needs review
StatusFileSize
new olark_2035919-1_no-widget-on-admin-pages.patch1.69 KB

Here's a patch.

Refactors the hook_page_alter() a bit besides adding the new functionality -- Boy Scout code and all.

bao truong’s picture

bao truong commented
Version: 7.x-1.x-dev » 7.x-1.0-beta1

Hey Adam, thanks for providing this patch, I can see that it is much needed. Still having trouble applying this patch cuase it doesn't seem to take, is this definitely for the 7.x-1.0-beta1 version?

adamdicarlo’s picture

adamdicarlo commented

It should apply just fine to beta1 though I rolled it off of 7.x-1.x (which is just one completely unrelated commit ahead of beta1).

Are you using `git am <patch>` after checking out this module's git repo (7.x-1.x branch)?

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Version: 7.x-1.0-beta1 » 7.x-1.x-dev
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new don_t_show_olark_widget-2035919-4.patch2.56 KB
new interdiff.txt1.32 KB

Added the variable removal on uninstall for all the variables including the new one, and a form option to toggle that.

Thanks for the original patch @adamdicarlo

Another way you can apply it without git:

Go to the olark folder from the command line:

curl https://www.drupal.org/files/issues/don_t_show_olark_widget-2035919-4.patch | patch -p1

Long hand with wget:

wget https://www.drupal.org/files/issues/don_t_show_olark_widget-2035919-4.patch
patch -p1 < don_t_show_olark_widget-2035919-4.patch

Also marking this as RTBC because the original code does the trick, my code (see interdiff) just adds fluff and polish;)

derekahmedzai’s picture

derekahmedzai commented

First patch (olark_2035919-1_no-widget-on-admin-pages.patch) works for me.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

@DerekAhmedzai does #4 not work for you?

derekahmedzai’s picture

derekahmedzai commented

No, it failed because of the paths in the patch (html/sites/all/modules/contrib/olark etc)

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
StatusFileSize
new don_t_show_olark_widget-2035919-8.patch2.31 KB

Oh how embarrassing;) It also needed a re-roll because there's been a commit since then.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Reviewed & tested by the community » Fixed

This is fixed and committed to -dev thanks for your help:)

  • joelpittet committed eae84ad on 7.x-1.x 
    Issue #2035919 by joelpittet, adamdicarlo, DerekAhmedzai, Bao Truong:...

  • joelpittet committed eae84ad on 8.x-1.x 
    Issue #2035919 by joelpittet, adamdicarlo, DerekAhmedzai, Bao Truong:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.