Test RDFa output in email formatter

#3: 2034975-03-email-field-test_includes2034977.patch queued for re-testing.

This needs reroll to incorporate #2034977: Create a base class for formatter RDFa tests.

renaming and re-posting patch to prepend issue number

As far as I can tell, we don't need to alter the email field formatter to support RDFa, since the wrapping element will receive the property attribute (default behavior). The test might need to be added for that though.

Minor fixes needed.

1. +++ b/core/modules/rdf/lib/Drupal/rdf/Tests/Field/EmailFieldRdfaTest.php
   @@ -0,0 +1,64 @@
   +class EmailFieldRdfaTest extends FieldRdfaTestBase {
   

   The class needs to be documented, for example this is taken from the text field test:
   +/**
   + * Tests the placement of RDFa in text field formatters.
   + */
   +class TextFieldRdfaTest extends FieldRdfaTestBase {

2. +++ b/core/modules/rdf/lib/Drupal/rdf/Tests/Field/EmailFieldRdfaTest.php
   @@ -0,0 +1,64 @@
   +      'name'  => 'Field formatter - email',
   

   The title needs to be consistent with other similar tests, for example:
   'name' => 'Field formatter: text',

code style fixes described in #9

fixed typo -was missing slash in comment tag (line 11)

+++ b/core/modules/rdf/lib/Drupal/rdf/Tests/Field/EmailFieldRdfaTest.php
@@ -0,0 +1,67 @@
+/**
+* Tests the placement of RDFa in email field formatters.
+*/
+class EmailFieldRdfaTest extends FieldRdfaTestBase {

Indentation issues, should be:

/**
 * Tests the placement of RDFa in text field formatters.
 */
class ...

(note the leading space on the second and third lines)

spacing fix (thanks for catching!)

+++ b/core/modules/rdf/lib/Drupal/rdf/Tests/Field/EmailFieldRdfaTest.php
@@ -0,0 +1,67 @@
+    $this->entity->save();
+    $uri_info = $this->entity->uri();
+    $this->uri = url($uri_info['path']);

These lines are not needed for the purpose of this test.

Remove the lines referenced in #16

Thanks Kelly. Patch looks good now.

+++ b/core/modules/rdf/lib/Drupal/rdf/Tests/Field/EmailFieldRdfaTest.php
@@ -0,0 +1,64 @@
+  /**
+   * Tests the plain formatter.
+   */
+  public function testPlainFormatter() {
+    $this->assertFormatterRdfa('text_plain', 'http://schema.org/email', $this->testValue);
+  }
+
+  /**
+   * Tests the mailto formatter.
+   */
+  public function testMailToFormatter() {
+    $this->assertFormatterRdfa('email_mailto', 'http://schema.org/email', $this->testValue);
+  }

Having two tests here means that we have to run test setup twice. Which looks a bit unnecessary - how about a testFormatters method with two assertions?

combined assertions into single method per #21

+++ b/core/modules/rdf/lib/Drupal/rdf/Tests/Field/EmailFieldRdfaTest.php
@@ -51,14 +51,8 @@ public function setUp() {
    * Tests the plain formatter.

Needs to be updated to say "Tests all the formatters.". Maybe also keep the comment for each assertion as well.

corrected general comment on method and added comment for each assertion per #24

All tests have been merged into one per #21 recommendation in #21. back to RTBC.

Committed 2020cb4 and pushed to 8.x. Thanks!