We added ContainerFactoryPluginBase in #1863816: Allow plugins to have services injected, but in a follow-up added ContainerFactoryPluginInterface as well.

Because the static create() method cannot be referenced by parent::, it is either ignored or overridden, always.

It's completely useless, and just pollutes the hierarchy of a plugin.

CommentFileSizeAuthor
#1 plugin-2033447-1.patch8.81 KBtim.plunkett

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Needs review
StatusFileSize
new plugin-2033447-1.patch8.81 KB
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Reviewed & tested by the community

Unless bot says otherwise.

Status: Reviewed & tested by the community » Needs work
Issue tags: -Plugin system

The last submitted patch, plugin-2033447-1.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs work » Needs review
Issue tags: +Plugin system

#1: plugin-2033447-1.patch queued for re-testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Reviewed & tested by the community

LocaleCronUpdateTest random fail

Status: Reviewed & tested by the community » Needs work
Issue tags: -Plugin system

The last submitted patch, plugin-2033447-1.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs work » Needs review
Issue tags: +Plugin system

#1: plugin-2033447-1.patch queued for re-testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Reviewed & tested by the community

Random testbot: Base table or view not found: 1146 Table 'drupaltestbotmysql.simpletest378211key_value' doesn't exist'
3rd time's the charm?

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed cd7ca03 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.