The sidebar should be on the right in RTL, not like this:


#1 drupal-installer_rtl-2033137-1.patch403 bytesyannickoo
PASSED: [[SimpleTest]]: [MySQL] 56,792 pass(es). View
_لاحة_تركيب___Drupal.png96.81 KBGábor Hojtsy


yannickoo’s picture

Status: Active » Needs review
855.82 KB
403 bytes
PASSED: [[SimpleTest]]: [MySQL] 56,792 pass(es). View

Just added a float: right; for the first sidebar.
Screen Shot 2013-07-02 at 17.56.25.png

Gábor Hojtsy’s picture

Status: Needs review » Reviewed & tested by the community

Looks good. I looked at the patch committed in #1337554: Develop and use separate branding for the installer and it did not have this in the last incarnation, so it was not something we lots in the RTL CSS integration, it was just simply a mistake.

yannickoo’s picture

I was confused because the patch included the installer-page-rtl.css file and when I cloned the Git repository it wasn't there. Gábor, do you know why the Seven's CSS files are not in a CSS directory? I know that this would be an extra issue but just asking :)

Gábor Hojtsy’s picture

Yeah RTL CSS is now integrated in base CSS files. Moving the CSS to a subdir would be its own issue, yup :)

LewisNyman’s picture

Looks good. +1 RTBC

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 9306022 and pushed to 8.x. Thanks!

hass’s picture

Could one of you guys RTBC the one line bugfix in #2028643: CSS files order is incorrect in RTL, please?

Automatically closed -- issue fixed for 2 weeks with no activity.