uc_order_add_line_item_form validate & submit callbacks doesn't pass values from $form_state (only orderID)

Adding patch

+update

Haha I was looking at this code for good couple minutes thinking this doesn't make sense. Then I realize this is a bug :).

Should we just pass all of $form_state, not just the 'values' key?

Yeap, good idea.

Would it be useful to have $order available in the callback? (..) The reason I ask about $order is that the callback parameters are ($op, $order) by default, and if possible I don't think we should pass $order sometimes and $form_state in other situations.

Sorry, can't agree. If you check hook_line_item() documentation then you can see $op 'load' and 'dispaly' are actually $order object but not for 'cart-preview'. In this case you have: (..) an array of of product objects for the items in the cart. If you need $order object then you can always load it by uc_order_load($form_state['order_id']);. And it's not always needed so then it will be just additional cost.

And maybe $form for consistency?

Sounds good.

To sum up I think to pass $form as $arg1 and $form_state as $arg2.
Moving..

your_module_line_item_callback($op, &$arg1) {}
..
$func('validate', $form_state['values']['order_id']);
$func('submit', $form_state['values']['order_id']);

to something like this:

your_module_line_item_callback($op, &$arg1, &$arg2 = NULL) {}
..
$func('validate', $form, $form_state);
$func('submit', $form, $form_state);

I'll try to submit new patch ASAP. Cheers.

Need to create a patch

Patch.

So.. anybody can review it? Thanks.

thx