It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.
Cruft left over from #1985470: Remove theme_link() just needs to be removed from the file.
Looks like it should also be removed from system.schema.yml and possibly probably system.install:
/** * Move system theme settings from variable to config. * * @ingroup config_upgrade */ function system_update_8043() { update_variables_to_config('system.performance', array( 'theme_link' => 'theme_link', )); }
Working on this at the NJ Drupal Code Sprint.
Patch includes changes to system.performance.yml, system.schema.yml, and system.install.
The last submitted patch, core-remove-theme-link-system-performance-2031219-3.patch, failed testing.
New patch with only the change to system.performance.yml
The patch doesn't apply.
I think we should go back to the patch in #3 and try to re-roll that one. We shouldn't leave a useless upgrade path or useless schema lying around.
Here is the patch that also remove from system.schema.yml and system.install.
I could not find any other instance/usage of that·
RTBC +1
Committed/pushed to 8.x, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.
Comments
Comment #1
star-szrLooks like it should also be removed from system.schema.yml and
possiblyprobably system.install:Comment #2
seantwalshWorking on this at the NJ Drupal Code Sprint.
Comment #3
seantwalshPatch includes changes to system.performance.yml, system.schema.yml, and system.install.
Comment #5
seantwalshNew patch with only the change to system.performance.yml
Comment #6
deneo commentedThe patch doesn't apply.
Comment #7
deneo commentedComment #8
tstoecklerI think we should go back to the patch in #3 and try to re-roll that one. We shouldn't leave a useless upgrade path or useless schema lying around.
Comment #9
deneo commentedHere is the patch that also remove from system.schema.yml and system.install.
Comment #10
dawehnerI could not find any other instance/usage of that·
Comment #11
fabianx commentedRTBC +1
Comment #12
catchCommitted/pushed to 8.x, thanks!