Cruft left over from #1985470: Remove theme_link() just needs to be removed from the file.

CommentFileSizeAuthor
#9 core-remove-theme-link-system-performance-2031219-9.patch1.41 KBdeneo
#7 core-remove-theme-link-system-performance-2031219-7.patch354 bytesdeneo
#5 core-remove-theme-link-system-performance-2031219-5.patch353 bytesseantwalsh
#3 core-remove-theme-link-system-performance-2031219-3.patch1.42 KBseantwalsh
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr commented

Looks like it should also be removed from system.schema.yml and possibly probably system.install:

/**
 * Move system theme settings from variable to config.
 *
 * @ingroup config_upgrade
 */
function system_update_8043() {
  update_variables_to_config('system.performance', array(
    'theme_link' => 'theme_link',
  ));
}
seantwalsh’s picture

seantwalsh
he/him
Primary language English
Location Eatontown, NJ
CreditAttribution: seantwalsh commented
Assigned: Unassigned » seantwalsh

Working on this at the NJ Drupal Code Sprint.

seantwalsh’s picture

seantwalsh
he/him
Primary language English
Location Eatontown, NJ
CreditAttribution: seantwalsh commented
Assigned: seantwalsh » Unassigned
Status: Active » Needs review
FileSize
core-remove-theme-link-system-performance-2031219-3.patch1.42 KB

Patch includes changes to system.performance.yml, system.schema.yml, and system.install.

Status: Needs review » Needs work

The last submitted patch, core-remove-theme-link-system-performance-2031219-3.patch, failed testing.

seantwalsh’s picture

seantwalsh
he/him
Primary language English
Location Eatontown, NJ
CreditAttribution: seantwalsh commented
Status: Needs work » Needs review
FileSize
core-remove-theme-link-system-performance-2031219-5.patch353 bytes

New patch with only the change to system.performance.yml

deneo’s picture

deneo CreditAttribution: deneo commented
Issue summary: View changes
Status: Needs review » Needs work

The patch doesn't apply.

deneo’s picture

deneo CreditAttribution: deneo commented
Status: Needs work » Needs review
FileSize
core-remove-theme-link-system-performance-2031219-7.patch354 bytes
tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented

I think we should go back to the patch in #3 and try to re-roll that one. We shouldn't leave a useless upgrade path or useless schema lying around.

deneo’s picture

deneo CreditAttribution: deneo commented
FileSize
core-remove-theme-link-system-performance-2031219-9.patch1.41 KB

Here is the patch that also remove from system.schema.yml and system.install.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

I could not find any other instance/usage of that·

Fabianx’s picture

Fabianx CreditAttribution: Fabianx commented

RTBC +1

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.