Test text formatter RDFa output

#3: 2030929-03-text-formatter-test_includes2034977.patch queued for re-testing.

Test passed locally.

Manual review looked good.

This needs reroll to incorporate #2034977: Create a base class for formatter RDFa tests.

This is linclark's 2030929-03-text-formatter-test-do-not-test.patch, renamed for clarity. It does not include the base class, which was was committed in #2034977

Setting to needs review

Added parent META issue.

1. --- /dev/null
   +++ b/core/modules/rdf/lib/Drupal/rdf/Tests/TextFieldRdfaTest.php
   

   should be in the Field directory inside Tests.

2. +++ b/core/modules/rdf/lib/Drupal/rdf/Tests/TextFieldRdfaTest.php
   @@ -0,0 +1,98 @@
   + * @file
   + * Contains \Drupal\rdf\Tests\TextFieldRdfaTest.
   + */
   +
   +namespace Drupal\rdf\Tests;
   

   same

3. +++ b/core/modules/rdf/lib/Drupal/rdf/Tests/TextFieldRdfaTest.php
   @@ -0,0 +1,98 @@
   + * Test the placement of RDFa in text field formatters.
   

   "Tests..."

4. +++ b/core/modules/rdf/lib/Drupal/rdf/Tests/TextFieldRdfaTest.php
   @@ -0,0 +1,98 @@
   +  /**
   +   * Modules to enable.
   +   *
   +   * @var array
   +   */
   +  public static $modules = array('text');
   

   should be:
   /**
   * {@inheritdoc}
   */

5. +++ b/core/modules/rdf/lib/Drupal/rdf/Tests/TextFieldRdfaTest.php
   @@ -0,0 +1,98 @@
   +      'name'  => 'Field formatter - text',
   

   Let's be consistent with taxonomy test which reads:
   'Field formatter: taxonomy term reference'

Patch with feedback from 9 above.

interdiff provided

10: 2030929-rdf-text_formatter_test-10.patch queued for re-testing.

Thanks @cwells! This test is good to go.

Yay, tests!

One question. When there are separate testFoo methods, each one will re-bootstrap the environment. Do we actually need a clean rebuild between each test run? Or will one bootstrap suffice? If so, we might want to do all of those assertions under one testX() function to save a bit of testbot time.

This is just a question, if it's incorrect feel free to post back to RTBC. In case it needs a re-roll, there's a tiny indentation problem in the PHPDoc above public static $modules. Else I can fix it on commit.

FieldRdfaTestBase which this test extends is actually a unit test (extends FieldUnitTestBase), and therefore it's ultra fast. There is no install going on here. Settings back to RTBC for re-evaluation.

Yeah, saw that, but it's actually a *Drupal*UnitTestCase which I thought did some (light) bootstrapping before each testX method. But if the performance gain isn't worth it, we can go with this.

Committed and pushed to 8.x. Thanks!

Currently working on same for number formatter. Are concerns raised in comments #15-17 something to address before implementing the pattern in this patch?

No, the number formatter should follow the same approach of using/extending FieldUnitTestBase.