Comments

mandarmbhagwat78’s picture

Status: Active » Needs review
StatusFileSize
new276 bytes

Here is the solution patch.

Status: Needs review » Needs work

The last submitted patch, views-ui-textarea-is-hidden-2029167.patch, failed testing.

mandarmbhagwat78’s picture

Assigned: Unassigned » mandarmbhagwat78
StatusFileSize
new402 bytes

Here is the updated patch.

mandarmbhagwat78’s picture

Assigned: mandarmbhagwat78 » Unassigned
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, views-ui-textarea-is-hidden-2029167.patch, failed testing.

dawehner’s picture

Please try to use the drupal core css style, which does not put everything in one line.

dawehner’s picture

Status: Needs work » Needs review
dawehner’s picture

I guess our css codestyle looks different, but in general I don't have a clue about css.

oadaeh’s picture

Status: Needs review » Needs work
oadaeh’s picture

Oh, I forgot to mention that, per @dawehner's request in #2031531-1: The text area does not display correctly, I will try to examine and test this on Saturday, when I should have a bit of free time, after I update my more than a month old ( :^( ) D8 installations.

oadaeh’s picture

Status: Needs work » Needs review
StatusFileSize
new458 bytes

The proposed fix does correct the problem for me. I've attached a patch that conforms to the CSS formatting guidelines.

oadaeh’s picture

StatusFileSize
new484 bytes

I've attached another patch that adds a partial fix for #2031531: The text area does not display correctly, because it's the same fix for this one.

oadaeh’s picture

Component: views.module » views_ui.module

Correcting the component.

oadaeh’s picture

StatusFileSize
new562 bytes

In testing #2031531: The text area does not display correctly to find the fixes to the last problems, I discovered the patch originally proposed to fix this problem was not correct. The attached patch is the correct fix for this problem, and it also fixes the additional, related problems in the other issue.

dawehner’s picture

Issue tags: +Novice, +Needs screenshots

Just for review it would be great to post a screenshot before and after.

oadaeh’s picture

pcambra supplied the before screen shot for Global: Unfiltered text.
Here is the after:
global-unfiltered-text-after.png

The before shot for the Global: Text area and the Basic HTML Text format (the Full HTML Text format is the same):
global-text-area-basic-html-before.png

The after shot for the Global: Text area and the Basic HTML Text format (the Full HTML Text format is the same):
global-text-area-basic-html-after.png

The before shot for the Global: Text area and the Restricted HTML Text format:
global-text-area-restricted-html-before.png

The after shot for the Global: Text area and the Restricted HTML Text format:
global-text-area-restricted-html-after.png

FYI, the appearance and behavior is the same for for Bartik, Seven, and Stark, and the fix applies correctly for all three themes.

yannickoo’s picture

Issue tags: -Needs screenshots
dobrzyns’s picture

I was able to apply the patch and tested in FF 22, Chrome 28.0.1500.95, and Safari 6.0.5 on Mac 10.8.4. The appearance is the same with both Seven and Bartik.

FF Before with Seven:
global-text-area-wysiwyg-before-firefox.png

FF After with Seven:
global-text-area-wysiwyg-after-firefox.png

The CSS looks good.

dobrzyns’s picture

Status: Needs review » Reviewed & tested by the community
alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 5f0fc08 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.