All "Submit" buttons should be named like the action that is behind. This has changed at D6 times and is a development rule. There are still Submit buttons in the module.

https://drupal.org/update/modules/5/6#submit-to-save

Comments

hass’s picture

Version: 7.x-3.9 » 7.x-3.x-dev
Status: Active » Needs review
StatusFileSize
new4.4 KB

Patch attached

quicksketch’s picture

Category: bug » task

I don't think "Save" is the right word here. As a user, I'm not "Saving" a submission, I'm "Submitting" it to the site. This is different than nodes, in which you're creating content. In Webform, we even call them "submissions" so by clicking the button you're creating a submission, hence "Submit" is the right terminology.

hass’s picture

We also Submitted a node, a download and other stuff in the past... Submit is extremely difficult to translate. Do you have any other suggestion? Save survey?

quicksketch’s picture

Save survey?

You can't really put a noun in here, other than maybe "form" or "submission", because not all webforms are surveys. A lot of people use webforms as a contact or support form for example, so making the default label include "survey" would make an incorrect label for a lot of forms.

We also should avoid "Save", because after we add the feature at #290448: Only email results, don't store results on the site, you won't be saving anything. You'll just be "Sending".

In all cases, I get the feeling that if you want a specific (accurate) label, you should just use the UI option for changing the label (under the Webform -> Form Settings tab).

hass’s picture

I know about the UI option. I just hoped to find an easier translatable word for the default. Aside, how are webforms translated?

quicksketch’s picture

Aside, how are webforms translated?

Webform provides hooks for altering just before fields/labels are displayed, and every element has an array of translatable properties. Combined, it makes it so that all the information is available to make translation possible. Webform itself doesn't provide an UI for this, instead it's handled by webform_localization.

However the more common thing is just to translate the node using the standard core Content Translation module, and just simply have different forms for each language. The Webform Localization module is only used when it's important to aggregate all results across languages.

In the case of the submit button, I think we just cheat and run it through t(). So whatever label a user enters in the UI will be translated via Locale module.

hass’s picture

That's fine then. Thanks for details.

hass’s picture

Status: Needs review » Closed (works as designed)

Moving to as designed.