Just tried to drush vget devel to find the memory display variable and it turned out it is named 'dev_mem'. Woops. Let's clean that up. Needs update function.

CommentFileSizeAuthor
#17 0001-Issue-2027987-by-chrisjlee-Added-Variable-.patch4.88 KBchrisjlee
#7 2027987-dev-mem-to-dev-memory-7.patch2.26 KBchrisjlee
#5 interdiff.txt1.1 KBchrisjlee
#5 2027987-dev-mem-to-dev-memory-5.patch1.1 KBchrisjlee
#1 2027987-dev-mem-to-dev-memory-1.patch2.63 KBchrisjlee

Comments

chrisjlee’s picture

chrisjlee commented
Category: bug » feature
Status: Active » Needs review
StatusFileSize
new 2027987-dev-mem-to-dev-memory-1.patch2.63 KB

I would agree. How does this sound?

chrisjlee’s picture

chrisjlee commented

Sorry double save...

salvis’s picture

salvis
he/his
commented
Status: Needs review » Needs work

'dev_memory'?

jody lynn’s picture

jody lynn
she/her
Primary language English
commented

Thanks chrisjlee. Looks like in the patch a few places said dev_memory that should say devel_memory.

chrisjlee’s picture

chrisjlee commented
Status: Needs work » Needs review
StatusFileSize
new 2027987-dev-mem-to-dev-memory-5.patch1.1 KB
new interdiff.txt1.1 KB

Good point! Whoops did that too fast.

Status: Needs review » Needs work

The last submitted patch, 2027987-dev-mem-to-dev-memory-5.patch, failed testing.

chrisjlee’s picture

chrisjlee commented
Assigned: Unassigned » chrisjlee
Status: Needs work » Needs review
StatusFileSize
new 2027987-dev-mem-to-dev-memory-7.patch2.26 KB

Interdiff is in 5. Patch in 5 is actually the interdiff again.

chrisjlee’s picture

chrisjlee commented

Anyone able to provide some feedback?

salvis’s picture

salvis
he/his
commented
Version: 7.x-1.x-dev » 8.x-1.x-dev

That looks reasonable for D7, but I haven't checked yet whether you really caught all occurrences.

Now, D8 needs to go first.

salvis’s picture

salvis
he/his
commented

#7: 2027987-dev-mem-to-dev-memory-7.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 2027987-dev-mem-to-dev-memory-7.patch, failed testing.

chrisjlee’s picture

chrisjlee commented

Respectfully salvis, Isn't this a Drupal 7 specific patch? Given that the variable (config) system has been reworked?

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented
Version: 8.x-1.x-dev » 7.x-1.x-dev

Yeah, I don't think this affects 8.x, "dev_mem" is now called "memory" and it's inside the devel container for config.

chrisjlee’s picture

chrisjlee commented
Status: Needs work » Needs review
chrisjlee’s picture

chrisjlee commented

#7: 2027987-dev-mem-to-dev-memory-7.patch queued for re-testing.

salvis’s picture

salvis
he/his
commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
Assigned: chrisjlee » Unassigned
Status: Needs review » Patch (to be ported)

Oops, you're both right of course. Thanks!

Pushed to 7.x-1.x-dev.

chrisjlee’s picture

chrisjlee commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new 0001-Issue-2027987-by-chrisjlee-Added-Variable-.patch4.88 KB
moshe weitzman’s picture

moshe weitzman commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Needs review » Fixed

Could we just leave poor 6.x alone? Whats the benefit of "cleaning this up" there.

chrisjlee’s picture

chrisjlee commented

Moshe: no idea. salvis asked for it and i've produced a patch. :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

salvis’s picture

salvis
he/his
commented

Sorry for wasting your time, chrisjlee...