Problem/Motivation

Comment module does not depends on datetime module but info file still has it as dependency.

Proposed resolution

Remove unused dependency

Remaining tasks

commit.

User interface changes

no

API changes

no

Original report by @Pancho

After #2006484: Remove dependency on datetime from node has been fully fixed, we should also remove dependency on datetime from comment.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task because it's planed to remove.
Issue priority Normal because could be done anytime...
Unfrozen changes Unfrozen because it only changes unused dependency...
Prioritized changes The main goal of this issue is removing previously deprecated code.
Disruption Disruptive for contributed and custom modules/themes because can relay on this dependency...
CommentFileSizeAuthor
#3 2027959-3.patch333 bytesandypost
#1 2027959-removedatetimedependency-1.patch351 bytesaburrows

Comments

aburrows’s picture

aburrows commented
Assigned: Unassigned » aburrows
Status: Active » Needs review
StatusFileSize
new 2027959-removedatetimedependency-1.patch351 bytes

Patch for this attached

Status: Needs review » Needs work

The last submitted patch, 2027959-removedatetimedependency-1.patch, failed testing.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue summary: View changes
Status: Needs work » Needs review
Related issues: +#2227503: Apply formatters and widgets to Comment base fields
StatusFileSize
new 2027959-3.patch333 bytes
andypost’s picture

andypost
he/him
Primary language Russian
commented
Assigned: aburrows » larowlan
Issue summary: View changes

Green! let's get rid of unused dependency

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Note that this is also done in #2227503: Apply formatters and widgets to Comment base fields.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed c0f0c2f and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation for to the issue summary.

  • alexpott committed c0f0c2f on 8.0.x 
    Issue #2027959 by andypost, aburrows: Remove dependency on datetime from...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.