If Conditional fields aren't using the role based configuration, it still takes up a fairly large chunk of the export feature definition (a lot of num => 0's). My proposal is to clean it up at the source, on insert/update of the values.

CommentFileSizeAuthor
#5 2027307-5.patch1.7 KBjoelpittet
#5 interdiff.txt541 bytesjoelpittet
#3 2027307-conditional_fields-export-clean-3.patch1.69 KBhefox
conditional_fields-export-0.patch1.64 KBhefox

Comments

finex’s picture

finex commented

Hi, the function added with the patch has been named "conditiona_fields_clean_up_options", shouldn't be "conditional_fields_clean_up_options" instead?

hefox’s picture

hefox commented
Status: Needs review » Needs work

...yes, lol. typos!

hefox’s picture

hefox commented
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new 2027307-conditional_fields-export-clean-3.patch1.69 KB
socialnicheguru’s picture

socialnicheguru commented

this seems to work

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new interdiff.txt541 bytes
new 2027307-5.patch1.7 KB

This works great to clean up my export. Thanks @hefox.

I changed one thing, the conditional_fields_dependency_update hook wasn't doing anything because it wasn't passing in options to work on.

Otherwise it worked perfectly. Sorry for the self RTBC, reset if you want a 3rd pair of eyes on it.

capysara’s picture

capysara commented

Worked for me!

Patch installed cleanly on 7.x-3.0-alpha2. I resaved the dependency and generated the feature and the extra => 0 were removed.

Thanks!

dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
commented

Apply/Test/Review ...

dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
commented

Works on latest 7.x dev.

  • dqd committed 0eed9e37 on 7.x-3.x authored by joelpittet 
    Issue #2027307 by hefox, joelpittet, dqd, SocialNicheGuru: Cleanup...
dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
commented
Status: Reviewed & tested by the community » Fixed

Thanks for the report and all the hard work in here, very much appreciated.

Reviewed and tested and committed to latest 7.x dev. Hope it still helps someone out there! But please consider updating Drupal to latest core since EOL of Drupal 7 is coming soon.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.