selecting "css scrollbox" has no effect (the legal module css refers to non existent identifiers). The T&C's for new user are always displayed in full. (this would appear to be identical to a dev issue cleared over a year ago).

Investigated as far as possible -- theme_legal_display uses prefix/suffix to add code .. this is being ignored. ISTR prefix/suffix only works on textfields, could this be the problem? had to resort to page_alter to get the code running!

Comments

Infoloko’s picture

Issue summary: View changes

additional information

jojonaloha’s picture

Version: 7.x-1.4 » 7.x-1.x-dev
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new691 bytes

Attached patch is a quick fix to this issue. Personally I don't like the idea of calling a theme function in a form alter though.. just leaves a bad taste in the mouth.

jojonaloha’s picture

Updated patch also fixes the scroll box when you submit the form and the form doesn't pass validation.

idebr’s picture

Status: Needs review » Reviewed & tested by the community

Lets leave the cleanup for later and fix the scrollbox first. Patch applies cleanly and fixes the Scrollbox on the user/register form. Thanks Jonathan!

idebr’s picture

Title: scroll box setting ignored » Scroll box (css) setting is not applied on the user registration form
ryanbriscall’s picture

If you look at the code in the module, it's clearly broken. Confused why it's released in such a state.

These patches (submitted by jojonaloha) fix the issue(s). So, why haven't they merged?

  • Robert Castelo committed b226ad0 on 7.x-1.x
    Issue #2026555 by jojonaloha: Scroll box (css) setting is not applied on...
robert castelo’s picture

Status: Reviewed & tested by the community » Fixed

Thanks jojonaloha, deployed to dev, will be in the next release (soon).

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.