It is very annoying if you need to remember to always right-click on that link to open it in a new tab or window, so you don't go out of Hostmaster site. This should be forced by default.

Comments

omega8cc’s picture

omega8cc commented
Status: Active » Needs review

Simple patch for review: http://drupalcode.org/sandbox/omega8cc/1074912.git/commit/4035462463464f...

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
commented

Aren't we better off adding target="_blank"?

omega8cc’s picture

omega8cc commented

Yeah, we could, even if the target method is no longer a valid XHTML. However, why to use invalid method if the Aegir interface requires javascript enabled anyway?

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
commented

It's back in HTML5: http://www.w3.org/TR/html5/browsers.html#valid-browsing-context-name-or-...

anarcat’s picture

anarcat commented
Status: Needs review » Needs work

This should be themed, not forced by default. Besides, we should look at how this is done elsewhere in Drupal.

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
commented
Status: Needs work » Fixed

Fixed in dc74e22.

I added a theme function, as per #5, and used target='_blank', since it's more commonly used in Drupal core.

anarcat’s picture

anarcat commented

damn you, i hate popups. oh well. ;)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit dc74e22 on 6.x-2.x, 7.x-3.x, dev-ssl-ip-allocation-refactor, dev-sni, dev-helmo-3.x by ergonlogic: 
    Issue #2025787 by omega8cc, ergonlogic, anarcat: Open site goto link in...

  • Commit dc74e22 on 6.x-2.x, 7.x-3.x, dev-ssl-ip-allocation-refactor, dev-sni, dev-helmo-3.x by ergonlogic: 
    Issue #2025787 by omega8cc, ergonlogic, anarcat: Open site goto link in...