Scald flash module can create successfully scald flash atoms, but they do not survive more than a couple of hours.
Actually, they are marked temporary in the file_managed table.

Added a hook_scald_atom_insert(), copied from audio module...

Comments

gifad’s picture

Also fixed some irrelevant code obviously coming from twitter module...

DeFr’s picture

Status: Active » Needs work

Makes sense.

Let's remove the omit_legend = TRUE; completely instead of commenting it out, and then the patch is good to go.

gifad’s picture

Status: Needs work » Needs review
StatusFileSize
new1.2 KB

Ok for the tweet comment, but can you give just two words on why scald_atom_insert is the right hook to use, instead of scald_register_atom, or scald_atom_presave ?

DeFr’s picture

Sure: that's due to the file usage call, to keep track of where the file is used. Both scald_register_atom and scald_atom_presave runs before the atom is saved, so you can't have access to $atom->sid.

gifad’s picture

... and $atom->sid is needed for file_usage.
Ok, thanks.

gaëlg’s picture

Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, scald_flash_atom_not_registered-2025773-3.patch, failed testing.

DeFr’s picture

Status: Needs work » Fixed

The patch was pushed during the DCParis code sprint (commit 32f5e) but I forgot to update the issue status, sorry about that.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.