Add CAPTCHA to all forms by default

How does this relates with the patch I've just committed for the 7.x branch?

See issue for 7,x #255795: Add CAPTCHA to all forms by default

Here is a patch which adds needed feature. This patch does not have any tests, since all tests for the settings form will be added here https://www.drupal.org/node/2802617

Hi @ddrozdik,

Thanks for looking into this. I have applied the patch on my d8 environment with captcha (8.x-1.x-dev) version. But unable to get positive result. This needs to be re-work.

Please let me know if more clarity needed and we can discuss further.

Hope this helps.

Thanks & Regards!!!

Here is some coding standard issues:

1. +++ b/captcha.module
   @@ -162,6 +162,11 @@ function captcha_form_alter(array &$form, FormStateInterface $form_state, $form_
   +    if(!$captcha_point && $config->get('enabled_default')){
   +        $captcha_point = captcha_set_form_id_setting($form_id, $config->get('default_challenge'));
   +        $captcha_point->enable();
   +    }
   

   1.1. There should be space before (
   1.2. Wrong indent (should be 2 spaces, but I see 4)

2. +++ b/src/Form/CaptchaSettingsForm.php
   @@ -92,6 +92,13 @@ class CaptchaSettingsForm extends ConfigFormBase {
   +      //Option for enabling CAPTCHA for all forms.
   

   2.1. Unnecessary spaces before //
   2.2. There is not space after //

I've reviewed more in details (hope it's clear):

1. +++ b/captcha.module
   @@ -162,6 +162,11 @@ function captcha_form_alter(array &$form, FormStateInterface $form_state, $form_
   +    if (!$captcha_point && $config->get('enabled_default')) {
   +      $captcha_point = captcha_set_form_id_setting($form_id, $config->get('default_challenge'));
   +      $captcha_point->enable();
   +    }
   

   I think it should be done in another approach. Here you create an entity for each form which stores in db.
   If I disable "enabled_default" option, all entities (CaptchaPoint) which were created before won't be removed.
   That's a problem. You do not need to create a CaptchaPoint.

2. +++ b/config/install/captcha.settings.yml
   @@ -1,3 +1,4 @@
   +enabled_default: 0
   

   can be just `false`

3. +++ b/config/schema/captcha.settings.yml
   @@ -5,6 +5,9 @@ captcha.settings:
   +      type: integer
   

   better to use `boolean`

4. +++ b/config/schema/captcha.settings.yml
   @@ -5,6 +5,9 @@ captcha.settings:
   +      label: 'Add captcha to all forms.'
   

   captcha => CAPTCHA

Thx, I fixed this problem, I just use fake instance without saving.

Many thanks, looks good for me and do not see any other issues so far.