From panels_edit_style_settings_form_validate in panels_renderer_editor class

My guess is that the display render is cached as init isn't being called for it either, so validation is being called but plugins file wasn't added, and bam fatal.

(very likely could be caused by something hackish I'm doing, but don't have the headspace to spend any more time on this atm.)

CommentFileSizeAuthor
#5 2024441-panels_standard_render_form_include-5.patch4.27 KBhefox
#4 2024441-panels_standard_render_form_include-4.patch3.77 KBhefox
panels_edit_style_settings_form_validate_include_plugins.patch780 byteshefox
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented

I suspect what is really needed here is to ensure that the plugin is part of the form_state['build_info'] which is handled by form_load_include() or the CTools analogue (which can be slightly easier to use sometimes). This would be done in the form itself, or potentially when the file was initially included if that happens after $form_state is instantiated. That would ensure that the cached form loads the file.

hefox’s picture

hefox CreditAttribution: hefox commented
Status: Needs review » Needs work

That sounds more reasonable than randomly including it there.

Just to clarify in case wasn't clear, the inclusion of class definition is fine, it's the plugin.inc file that is missing.

My brain is quite dead atm though

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented

Yeah, I believe you just need to find the right spot to put this:

ctools_form_include($form_state, 'plugins', 'panels');
hefox’s picture

hefox CreditAttribution: hefox commented
Status: Needs work » Needs review
FileSize
2024441-panels_standard_render_form_include-4.patch3.77 KB

Adding include of plugins (via ctools_form_include) and that class file (via form_load_include) to all form definitions defined in there. It's a place that works, but not sure if it's the best place to add them though

hefox’s picture

hefox CreditAttribution: hefox commented
FileSize
2024441-panels_standard_render_form_include-5.patch4.27 KB

why in the world was my local copy of panels on branch 6.x-3.x... (I keep a lot of checked out repos to just roll patches against, not connected to any site)...

mpotter’s picture

mpotter CreditAttribution: mpotter commented
Status: Needs review » Reviewed & tested by the community

Yeah, this seems to work for me in OA2.

SocialNicheGuru’s picture

SocialNicheGuru CreditAttribution: SocialNicheGuru commented

the patch in the original post and in #5 are different. Are they additive or does #5 replace the original?

hefox’s picture

hefox CreditAttribution: hefox commented

5 replaces original

pirog’s picture

pirog CreditAttribution: pirog commented

This patch also seems to resolve some intermittent issues in Kalatheme as well
#2173383: Kalacustomize for panes not working

japerry’s picture

japerry
Location KVUO
CreditAttribution: japerry commented
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

I was having this issue as well periodically in commons, usually when on a new install. After using this patch I haven't been able to replicate the issue.

Marking fixed and committed!
http://drupalcode.org/project/panels.git/commit/856ba03

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

  • Commit 856ba03 on 7.x-3.x, 8.x-3.x authored by hefox, committed by japerry: 
    Issue #2024441 by hefox: Fix fatal error on panels_plugin_get_function...