I find that
1) I sometimes type slower than 2 chars in less than half a second (the 500ms timeout)
2) I'm changing 2+ items like select boxes.

Proposal: Change auto-submit to have a small timeout that checks if the form has changed or any new keys pressed during the time.

CommentFileSizeAuthor
#15 2023705-ctools-autosubmit-15.patch2.7 KBk4v
#13 ctools-bef-syntax-error-2.png23.3 KBmstrelan
#13 ctools-bef-syntax-error-1.png19.62 KBmstrelan
#6 2023705-ctools-autosubmit-2.patch2.65 KBhefox
#4 2017159_panopoly_magic_preview_post_render-5.patch7.39 KBhefox
#3 2023705-ctools-autosubmit-2.patch2.65 KBhefox
#2 2023705-ctools-autosubmit-1.patch2.65 KBhefox
ctools_autsubmit-wait.patch2.75 KBhefox

Comments

hefox’s picture

hefox commented
Status: Active » Needs review
hefox’s picture

hefox commented
StatusFileSize
new 2023705-ctools-autosubmit-1.patch2.65 KB

Accidentally removed the d from drupal

hefox’s picture

hefox commented
StatusFileSize
new 2023705-ctools-autosubmit-2.patch2.65 KB

Perhaps 5s is a bit tooo long

hefox’s picture

hefox commented
StatusFileSize
new 2017159_panopoly_magic_preview_post_render-5.patch7.39 KB

Need to use values instead of input

Status: Needs review » Needs work

The last submitted patch, 2017159_panopoly_magic_preview_post_render-5.patch, failed testing.

hefox’s picture

hefox commented
StatusFileSize
new 2023705-ctools-autosubmit-2.patch2.65 KB

I guess I could add the actual patch

hefox’s picture

hefox commented
Status: Needs work » Needs review

*headdesk* Please ignore the last few comments, uploaded to wrong issue queue.

mpotter’s picture

mpotter commented
Status: Needs review » Reviewed & tested by the community

This is very helpful when using a Filter in a collapsed fieldset. Definitely a better user experience.

ronino’s picture

ronino commented
Status: Reviewed & tested by the community » Needs work

I applied #6 and got the JavaScript error "Uncaught SyntaxError: Unexpected identifier" when the form should have been submitted. Chrome doesn't give me a hint where that error comes from, but it doesn't appear without the patch.

cockers’s picture

cockers commented
Issue summary: View changes

I didn't get any error messages, but auto submit had just stopped working after applying this patch.

quotesbro’s picture

quotesbro commented

#6 worked for me.

quotesbro’s picture

quotesbro commented
Title: autosubmit: Don't submit form while user is activally changing it » autosubmit: Don't submit form while user is actively changing it
mstrelan’s picture

mstrelan commented
StatusFileSize
new ctools-bef-syntax-error-1.png19.62 KB
new ctools-bef-syntax-error-2.png23.3 KB

Same result as #9. Using Better Exposed Filters with checkboxes and autocomplete.

Javascript error
CTools Error

Debugging the error
CTools Error

diamondsea’s picture

diamondsea
he/him/his
Primary language English
commented

FYI, I have also posted a user-configurable solution in #2781117: Configurable timeouts on auto-submit, ignore Enter key option.

k4v’s picture

k4v commented
StatusFileSize
new 2023705-ctools-autosubmit-15.patch2.7 KB

For my project #6 worked, here's a reroll for current dev.

japerry’s picture

japerry
Location KOMK
commented
Status: Needs work » Closed (outdated)

Drupal 7 is no longer supported, closing.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.