Utilise reviewDataItemElement() to attach gengo comments to data items

Tests are currently broken, which makes this a bug.

+++ b/tmgmt_mygengo.moduleundefined
@@ -34,7 +34,12 @@ define('TMGMT_MYGENGO_COMMENTS_CACHE_EXPIRE', 900);
+  // @todo - can we rely on this?
+  $parts = explode('|', $target_key);
+  $field = $parts[0];
+  return $form['review'][$field][$target_key]['below'][$gengo_job_id . '_gengo']['comments_wrapper'];

Hm. We probably can, but we shouldn't call it $field.

There's always a first key on that level, maybe $top_key?

It's a bit ugly that we have to know about this here.

+++ b/tmgmt_mygengo.ui.incundefined
@@ -12,125 +12,116 @@
+    $mapping = NULL;
+    foreach ($item->getRemoteMappings() as $mapping) {
+      if ($mapping->data_item_key == $data_item_key) {
+        break;
       }
+      unset($mapping);
+    }
 
-      // Create key which is used in the review form.
-      $key = str_replace('][', '|', $remote->data_item_key);
-      // Add into mapping data array.
-      $remotes[$key] = $remote;
+    // No mapping found for given data item - nothing to do.
+    if (empty($mapping)) {
+      return $form;

Hm. That's a bit hard to understand. We could extend the method and add an optional $data_item_key argument? This might be something that other translators will use too...

Alternatively, I'd prefer a separate variable that is set in the if instead of the unset().

Also, speaking of tests, we have a hen/egg problem here. Apart from the fact that tests are already broken (the testbot just doesn't know yet, but we can change that be forcing the branch to be test), we won't be able get them green, because we now rely on code that is not in alpha3. So to use that, we first need release a new version. But then this module won't work together with that version before we commit it. So I think for now, I'll force a branch test to postpone patches here. Then we need to run tests manually and release both modules at the same time.

Tested this manually. Noticed a few strange things...

- When requesting a revision, the status icon doesn't update, it stays yellow. After a manual refresh, it's correct.
- The same seems to happen for revisions, the message was displayed but text was not updated, after a refresh it's ok.
- Also had a strange case where all my jobs were suddenly set to needs review, not sure what triggered it exactly.

Did not have any issues with gengo, my jobs showed up there as they're supposed to.

No, not strange at all :)

See last paragraph in #5.

The testbot uses the latest release of tmgmt core, which doesn't have those methods yet, so nothing is added to the form and the tests fail.

To make the tests pass, I need to release a new alpha/beta of core, then commit this and then create a release for this.

Run the tests locally, still getting some notice exceptions?

Undefined index: ajaxid Notice tmgmt_mygengo.ui.inc 87 TMGMTMyGengoTranslatorUIController->reviewDataItemElement()

thanks, committed and pushed. Opened #2032869: Remove update is ignored if text did not change and data item is in pending state for the core bug that I found.