Whenever you create a new component, you get this error:

Notice: Undefined index: name in webform_component_defaults() (line 1080 of sites/all/modules/webform/includes/webform.components.inc).

This seems to have been introduced in #1287382: Use invisible instead of non-existent field labels for accessibility.

CommentFileSizeAuthor
#1 webform_title_attribute-2020705.patch1.17 KBquicksketch

Comments

quicksketch’s picture

quicksketch
he/him
commented
Status: Active » Needs review
StatusFileSize
new webform_title_attribute-2020705.patch1.17 KB

It looks like this was added in an attempt to meet this requirement:

The WCAG 2.0 guidelines at http://www.w3.org/TR/2010/NOTE-WCAG20-TECHS-20101014/H65.html recommends the use of the "title" attribute to label form controls when the visual design cannot accommodate the label.

But what ended up happening in that issue is that the title attribute ended up getting set on ALL components all the time. That was unneccessary, since only the fields that didn't have labels displayed where the ones intended to get title attributes. This patch moves the logic to theme_webform_element() and makes it have the correct behavior.

quicksketch’s picture

quicksketch
he/him
commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.