This is a sub-issue of #1910606: Improve the configurations schemas for Views significantly.

Problem/motivation

#1866610: Introduce Kwalify-inspired schema format for configuration introduced some config schema coverage for views and #1910606: Improve the configurations schemas for Views significantly extended it, but it is not complete. The changelog leads to (hopefully extensive) documentation on the format at http://drupal.org/node/1905070. While there are little cleanups planned for the format overall, the current format is a result of months of back and forths, so it should be perfectly fine to apply it more widely to core.

Proposed solution

Figure out the missing pieces that are not yet covered. Write schema file sections for them. Clean up / fix any issues in current schema.

Create a configuration schema for missing view fields plugins

Schema in place
Please refer core/modules/views/config/schema/views.field.schema.yml
Boolean.php
Broken.php
Counter.php
Custom.php
Date.php
FileSize.php
Links.php
MachineName.php
Numeric.php
PrerenderList.php
Serialized.php
Standard.php
TimeInterval.php
Url.php

Schema not yet in place
Dropbutton.php
Markup.php
Xss.php

Steps to review

Check Steps to check on meta.

Files: 
CommentFileSizeAuthor
#10 2019079-diff-3-10.txt1.17 KBvijaycs85
#10 2019079-config-schema-view-field-10.patch1.11 KBvijaycs85
PASSED: [[SimpleTest]]: [MySQL] 59,255 pass(es). View
#3 2019079-config-schema-views-fields-2.patch588 bytesNitesh Sethia
PASSED: [[SimpleTest]]: [MySQL] 59,292 pass(es). View
#1 2019079-config-schema-views-fields-1.patch0 bytesNitesh Sethia
PASSED: [[SimpleTest]]: [MySQL] 56,612 pass(es). View

Comments

Nitesh Sethia’s picture

Status: Active » Needs review
FileSize
0 bytes
PASSED: [[SimpleTest]]: [MySQL] 56,612 pass(es). View

Issuing initial patch for remaining field types...

Nitesh Sethia’s picture

Issuing initial patch for remaining field types...

Nitesh Sethia’s picture

FileSize
588 bytes
PASSED: [[SimpleTest]]: [MySQL] 59,292 pass(es). View

Issuing initial patch for remaining field types...

Status: Needs review » Needs work
Issue tags: -Configuration system, -D8MI, -language-config, -VDC, -Configuration schema, -views configuration schema

The last submitted patch, 2019079-config-schema-views-fields-2.patch, failed testing.

vijaycs85’s picture

Issue summary: View changes

Updated issue summary.

neetu morwani’s picture

I went through Dropbutton.php , Markup.php , Xss.php files. None of the options is defined in defineOptions() function. Because there are no options, mapping for these could not be added in views.field.schema.yml file. I guess,Schema for the Dropbutton, Markup, Xss is in place. We can even add Dropbutton field in the view.

vijaycs85’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 3: 2019079-config-schema-views-fields-2.patch, failed testing.

The last submitted patch, 3: 2019079-config-schema-views-fields-2.patch, failed testing.

vijaycs85’s picture

Status: Needs work » Needs review
vijaycs85’s picture

Issue summary: View changes
FileSize
1.11 KB
PASSED: [[SimpleTest]]: [MySQL] 59,255 pass(es). View
1.17 KB

Updating more field plugins

vijaycs85’s picture

dawehner’s picture

Status: Needs review » Needs work
+++ b/core/modules/views/config/schema/views.field.schema.yml
@@ -51,6 +51,22 @@ views.field.date:
+views.field.dropbutton:
+  type: views_field
+  label: 'Drop button'
+
+views.field.dropbutton:
+  type: views_field
+  label: 'Drop button'
+

This is two time the same, this cannot be right. additional this extends the links class which actually has some configuration we should inherit from.

vijaycs85’s picture

Status: Needs work » Closed (duplicate)
Related issues: +#2167623: Add test for all default configuration to ensure schema exists and is correct

The patch on this issue has been updated as part of #2167623: Add test for all default configuration to ensure schema exists and is correct. As this issue doesn't have any test to confirm/validate the schema, making this change and closing this issue as duplicate of #2167623: Add test for all default configuration to ensure schema exists and is correct. The contributors of this issue (in commit message) is copied to #2167623: Add test for all default configuration to ensure schema exists and is correct.