It was refactored in the main template.php but the commented out STARTER version is still the old one from Foundation 3

CommentFileSizeAuthor
#4 reroll-zf-top-bar-starter-theme-2018739-1.patch3.35 KBchrisjlee
#1 zurb-foundation-top-bar-starter-theme-2018739-1.patch3.35 KBalexweber

Comments

alexweber’s picture

alexweber commented
Status: Active » Needs review
StatusFileSize
new zurb-foundation-top-bar-starter-theme-2018739-1.patch3.35 KB

Easy fix :)

chrisjlee’s picture

chrisjlee commented

Looks good so far. If someone else can rtbc i'll commit it. :)

alexweber’s picture

alexweber commented

Let's wait for this one first: #2020135: Basic theme settings for menu/mobile rendering

chrisjlee’s picture

chrisjlee commented
Assigned: Unassigned » alexweber
Status: Needs review » Fixed
StatusFileSize
new reroll-zf-top-bar-starter-theme-2018739-1.patch3.35 KB

Looks good to me. Reroll attached. Thanks for doing this:

Commited: http://drupalcode.org/project/zurb-foundation.git/commit/77c69cb

alexweber’s picture

alexweber commented

Awesome thanks Chris!

ishmael-sanchez’s picture

ishmael-sanchez commented
Assigned: alexweber » chrisjlee
Status: Fixed » Needs work

Actually I had an issue with the new menu rendering because I wasn't using jquery_update and looking at the base theme a line is commented out (see 582 template.php) that loads the JS from the vendor folder, see Reverting fixes from rebase of variable patch Chris can you uncomment and commit thanks!

alexweber’s picture

alexweber commented

Related issue: #2001944: Include Zepto.js as a fallback if no jQuery Update is not present

chrisjlee’s picture

chrisjlee commented

@ishmael I'm confused. What are you asking? I think I commented that functionality out because it was breaking other functionality. And shouldn't we move this discussion to #2001944: Include Zepto.js as a fallback if no jQuery Update is not present ?

alexweber’s picture

alexweber commented
Assigned: chrisjlee » Unassigned
Status: Needs work » Closed (duplicate)

Closing as a duplicate of #2001944: Include Zepto.js as a fallback if no jQuery Update is not present