This came up in #1190436-59: Full Pager: The ellipsis ("...") button does nothing.

PS: I'm setting this issue to the theme system component because that other issue was filed against it as well. Feel free to change to a more appropriate component.

Comments

vijaycs85’s picture

StatusFileSize
new7.39 KB
new92.66 KB

Straightforward find & replace and validated in page and looks working fine.

Avoided few places (like below) as they are loading on JS and not replacing HTML entity.

diff --git a/core/modules/edit/js/editors/formEditor.js b/core/modules/edit/js/editors/formEditor.js
index 5b6ef7a..e143840 100644
--- a/core/modules/edit/js/editors/formEditor.js
+++ b/core/modules/edit/js/editors/formEditor.js
@@ -60,7 +60,7 @@ Drupal.edit.editors.form = Drupal.edit.EditorView.extend({
     // Render form container.
     var $formContainer = this.$formContainer = $(Drupal.theme('editFormContainer', {
       id: id,
-      loadingMsg: Drupal.t('Loading…')}
+      loadingMsg: Drupal.t('Loading<E2><80><A6>')}
     ));
     $formContainer
       .find('.edit-form')
diff --git a/core/modules/system/system.admin.inc b/core/modules/system/system.admin.inc
index b4eed78..6177dfd 100644
--- a/core/modules/system/system.admin.inc
+++ b/core/modules/system/system.admin.inc
@@ -795,7 +795,7 @@ function system_modules($form, $form_state = array()) {
     '#type' => 'search',
     '#title' => t('Search'),
     '#size' => 30,
-    '#placeholder' => t('Enter module name&hellip;'),
+    '#placeholder' => t('Enter module name<E2><80><A6>'),
     '#attributes' => array(
       'class' => array('table-filter-text'),
       'data-table' => '#system-modules',
vijaycs85’s picture

Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 12018591-replace-dots-1.patch, failed testing.

tim.plunkett’s picture

Status: Needs work » Needs review

#1: 12018591-replace-dots-1.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 12018591-replace-dots-1.patch, failed testing.

bleen’s picture

+++ b/core/modules/system/lib/Drupal/system/Tests/Mail/HtmlToTextTest.phpundefined
@@ -155,7 +155,7 @@ public function testTags() {
+      '<q>I <em>will</em> be back&hellip;</q>' => "I /will/ be back&hellip;\n",

This is actually a test for unicode chars so we dont want to change it here

The same is true for the unicodeTest.php changes...

vijaycs85’s picture

Status: Needs work » Needs review
StatusFileSize
new2.38 KB
new6.6 KB

thanks for the review @bleen18. here is the patch without #6

Status: Needs review » Needs work

The last submitted patch, 2018591-replace-dots-7.patch, failed testing.

bleen’s picture

I think this should be removed from all the unicode code (including tests) which only leaves the pager changes...

sun’s picture

Please take note of prior art in history. Drupal intentionally uses the UTF-8 character for an ellipsis (instead of 3 dots).

Drupal generates UTF-8 output, so there is no need to use an HTML entity. Especially for non-Latin languages, a different UTF-8 character/string might be used.

hanno’s picture

Especially for non-Latin languages, a different UTF-8 character/string might be used.

So, we need to make the ellipsis character … translatable? So that in Mongolian script it would be ᠁, in Thai ฯ, and in Japanese ……
$ellipsis = static::substr(t('…'), 0, $max_length);

damien tournoud’s picture

This seems won't fix. There is no reason to use an HTML entity here.

damien tournoud’s picture

Status: Needs work » Closed (won't fix)