Closed (won't fix)
Project:
Drupal core
Version:
8.0.x-dev
Component:
theme system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
13 Jun 2013 at 09:17 UTC
Updated:
29 Jul 2014 at 22:31 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
vijaycs85Straightforward find & replace and validated in page and looks working fine.
Avoided few places (like below) as they are loading on JS and not replacing HTML entity.
Comment #2
vijaycs85Comment #4
tim.plunkett#1: 12018591-replace-dots-1.patch queued for re-testing.
Comment #6
bleen commentedThis is actually a test for unicode chars so we dont want to change it here
The same is true for the unicodeTest.php changes...
Comment #7
vijaycs85thanks for the review @bleen18. here is the patch without #6
Comment #9
bleen commentedI think this should be removed from all the unicode code (including tests) which only leaves the pager changes...
Comment #10
sunPlease take note of prior art in history. Drupal intentionally uses the UTF-8 character for an ellipsis (instead of 3 dots).
Drupal generates UTF-8 output, so there is no need to use an HTML entity. Especially for non-Latin languages, a different UTF-8 character/string might be used.
Comment #11
hanno commentedSo, we need to make the ellipsis character … translatable? So that in Mongolian script it would be ᠁, in Thai ฯ, and in Japanese ……
$ellipsis = static::substr(t('…'), 0, $max_length);Comment #12
damien tournoud commentedThis seems won't fix. There is no reason to use an HTML entity here.
Comment #13
damien tournoud commented