Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Depends on #1969728: Implement Field API "field types" as TypedData Plugins
Instructions are on #2014671: [META] Convert all field types to plugins
Comment | File | Size | Author |
---|---|---|---|
#10 | 2017139-10.patch | 9.26 KB | amateescu |
#10 | interdiff.txt | 2.03 KB | amateescu |
#8 | 2017139-8.patch | 9.32 KB | amateescu |
#8 | interdiff.txt | 1.54 KB | amateescu |
#6 | 2017139-6.patch | 9.34 KB | amateescu |
Comments
Comment #1
swentel CreditAttribution: swentel commentedTagging
Comment #2
swentel CreditAttribution: swentel commentedInitial patch, can't get it to save stuff though.
Comment #3
swentel CreditAttribution: swentel commentedNote that default_token_formatter should go from the patch.
Comment #4
linclark CreditAttribution: linclark commentedI think dates not saving could be an underlying problem. I've been running into the issue in a serialization patch.
These two lines of code should be the same (they are in the case of text fields), but they aren't behaving the same:
$entity->get($field_name)->offsetGet(0)->setValue(array('value' =>$iso_date));
$entity->get($field_name)->offsetGet(0)->get('value')->setValue($iso_date);
I had created #2019587: Add test coverage for DateTimeItem to add tests for that issue.
Comment #5
swentel CreditAttribution: swentel commentedComment #6
amateescu CreditAttribution: amateescu commentedRecreated the patch :)
Comment #8
amateescu CreditAttribution: amateescu commentedAnd this one should work.
Comment #9
yched CreditAttribution: yched commentedThis looks good, but I'd rather let #2051177: Make existing ConfigFieldItem subclasses usable by base fields get in first :-)
Comment #10
amateescu CreditAttribution: amateescu commentedThat one just got in, here's an updated patch.
Comment #11
yched CreditAttribution: yched commentedLooks good. Thanks !
Comment #12
alexpottCommitted 362e5f8 and pushed to 8.x. Thanks!
Comment #13
xjmSeveral API changes here that it took me a git bisect to find :)
Comment #14
xjmNever mind; these are just hook implementations. Sorry @beejeebus. :)
Comment #16
xjmDarn you d.o.