Views listing page links are broken for default task page displays

Nice stuff!

I try to figure out why there can't be a unit test instead and I can't think of one.

+++ b/core/modules/views_ui/lib/Drupal/views_ui/ViewListController.phpundefined
@@ -156,4 +157,31 @@ public function render() {
+          $all_paths[] = check_plain('/' . $path);

Should be String::checkPlain() now.

#4: vdc-2016939-4.patch queued for re-testing.

That looks good to me.

Needs a reroll

curl https://drupal.org/files/vdc-2016939-4.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  7508  100  7508    0     0   3339      0  0:00:02  0:00:02 --:--:--  4506
error: patch failed: core/modules/views/lib/Drupal/views/Tests/ViewStorageTest.php:221
error: core/modules/views/lib/Drupal/views/Tests/ViewStorageTest.php: patch does not apply
error: patch failed: core/modules/views_ui/lib/Drupal/views_ui/ViewListController.php:2
error: core/modules/views_ui/lib/Drupal/views_ui/ViewListController.php: patch does not apply

#9: vdc-2016939-9.patch queued for re-testing.

Just some additional mocking is required to add a test for that.

Let me fix the use statements fast.

+++ b/core/modules/views/lib/Drupal/views/DisplayBag.phpundefined
@@ -46,7 +47,7 @@ public function __construct(ViewExecutable $view, PluginManagerInterface $manage
+    $this->instanceIDs = MapArray::copyValuesToKeys(array_keys($display));

Seems vaguely related, but ok :) These things need to be switched out anyway.

+++ b/core/modules/views_ui/lib/Drupal/views_ui/ViewListController.phpundefined
@@ -229,4 +230,31 @@ protected function getDisplaysList(EntityInterface $view) {
+   *   The view object.

The view entity ('instance' also maybe)?

+++ b/core/modules/views_ui/tests/Drupal/views_ui/Tests/ViewListControllerTest.phpundefined
@@ -69,6 +71,38 @@ public function testBuildRowEntityList() {
+

Additional space

+++ b/core/modules/views_ui/tests/Drupal/views_ui/Tests/ViewListControllerTest.phpundefined
@@ -69,6 +71,38 @@ public function testBuildRowEntityList() {
+    $container = new ContainerBuilder();
+    $executable_factory = new ViewExecutableFactory();
+    $container->set('views.executable', $executable_factory);
+    $container->set('plugin.manager.views.display', $display_manager);
+    \Drupal::setContainer($container);

We go to desperate measures to unit test a method nowadays!

+++ b/core/modules/views_ui/tests/Drupal/views_ui/Tests/ViewListControllerTest.phpundefined
@@ -98,6 +134,7 @@ public function testBuildRowEntityList() {
+    $this->assertEquals($row['data']['path'], '/test_page', 'The path of the page display is not rendered.');

I don't think this message is really what's being tested?

The point is that the message is just shown/displayed if the test failed.

Yep, but it still seems like it's not really what the test is going. No rendering involved.

If we can't come up with a better title, let's drop it?

Fixed the points.

Needs a reroll..

git applyc https://drupal.org/files/vdc-2016939-26.patch
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 12022  100 12022    0     0   5341      0  0:00:02  0:00:02 --:--:--  7711
error: patch failed: core/modules/views_ui/lib/Drupal/views_ui/ViewListController.php:133
error: core/modules/views_ui/lib/Drupal/views_ui/ViewListController.php: patch does not apply

Rerolled.

Committed 2f872b8 and pushed to 8.x. Thanks!

Manually tested all looks good