We noticed that the Webform Error message for a field of type time its italic when none of the other field types is.

CommentFileSizeAuthor
#8 webform-webform_error_message-2016821-7.patch2.48 KBdanchadwick
#4 webform-webform_error_message-2016821-4.patch6.66 KBdanchadwick
#2 webform-errortimeitalic-2016821-2.patch1.52 KBoriol masjuan
#1 webform-errortimeitalic-2016821-2.patch1.52 KBoriol masjuan

Comments

oriol masjuan’s picture

oriol masjuan commented
StatusFileSize
new webform-errortimeitalic-2016821-2.patch1.52 KB

Here it is a little patch that corrects the error.

oriol masjuan’s picture

oriol masjuan commented
StatusFileSize
new webform-errortimeitalic-2016821-2.patch1.52 KB

The previous patch has a '-' that needs to be removed. Here the patch that corrects that.

danchadwick’s picture

danchadwick commented
Version: 7.x-3.18 » 7.x-4.x-dev
Issue summary: View changes
Status: Patch (to be ported) » Needs work

At this point, 7.x-3.x is receiving critical bug fixes only. Please update to 7.x-4.x.

Actually they should all be in italics, using the % placeholder. I see that at least the date validation error is not. Need to check others.

danchadwick’s picture

danchadwick commented
Status: Needs work » Fixed
StatusFileSize
new webform-webform_error_message-2016821-4.patch6.66 KB

The core "required" error message does not use the % placeholder and does not use italics. For consistency with this, I changed:

  1. Grid unique -- previously used italics
  2. Number (numerous error messages) -- previously used % placeholder, which double-encoded HTML in the component name
  3. Time -- previously used % placeholder on unsanitized title, which removed more HTML than needed and ended up in italics.

Committed to 7.x-4.x and 8.x.

danchadwick’s picture

danchadwick commented
Version: 7.x-4.x-dev » 8.x-4.x-dev

  • DanChadwick committed 2aec31a on 7.x-4.x 
    Issue #2016821 by DanChadwick: Fixed Webform error  message for time...
  • DanChadwick committed 89e4336 on 8.x-4.x
    Issue #2016821 by DanChadwick: Fixed Webform error message for time...

  • DanChadwick committed 55e9363 on 7.x-4.x 
    Issue #2016821 DanChadwick: Fixed tests for Webform error message for...
  • DanChadwick committed a51f05f on 8.x-4.x
    Issue #2016821 DanChadwick: Fixed tests for Webform error message for...
danchadwick’s picture

danchadwick commented
StatusFileSize
new webform-webform_error_message-2016821-7.patch2.48 KB

Alas, the tests needed updating. Stupid fragile test. Grumble, grumble. Committed to 7.x-4.x and 8.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

danchadwick’s picture

danchadwick commented
Version: 8.x-4.x-dev » 7.x-4.x-dev