Included patch based off 7.x-1.x 8d11f7d17114adfdeb4330cbbb37d8088869dacc

If you are using feeds to import nodes that have comments, you would need the option to map target based on the feeds guid of the target node, in order for the the comments to be attached properly.

Also, in D7, you can specify additional comment fields on a per content type basis, and it would be great to be able to import into those fields in a standard way.

CommentFileSizeAuthor
#3 commentfields-2016217-2.patch3.88 KBharings_rob
feeds_comment_processor-d7-feeds-fix.patch7.54 KBjdillick

Comments

jdillick’s picture

jdillick commented
Status: Active » Needs review
danepowell’s picture

danepowell commented
Title: Add Feeds imported node GUID mapping target and per content type comment fields support. » Per content type comment fields support
Status: Needs review » Needs work

Can you please remove the GUID mapping functionality- that will be added in #1525308: Make feeds_comment_processor take a guid from a node that was imported with Feeds and find the correct NID

harings_rob’s picture

harings_rob commented
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new commentfields-2016217-2.patch3.88 KB

Hi,

I fixed the patch for the latest dev.

paulwdru queued 3: commentfields-2016217-2.patch for re-testing.

paulwdru’s picture

paulwdru commented

Hi harings_rob,

I run commentfields-2016217-2.patch against http://ftp.drupal.org/files/projects/feeds_comment_processor-7.x-1.x-dev... , and the following error occured ? Which patch for which version of module ? Could you upload your version of module ? Thanks

patch -p1 --dry-run < commentfields-2016217-2.patch
checking file FeedsCommentProcessor.inc
checking file feeds_comment_processor.info
Reversed (or previously applied) patch detected! Assume -R? [n]

Anonymous’s picture

Anonymous (not verified) commented

patch #3 worked for me, thanks

twistor’s picture

twistor commented
Assigned: jdillick » twistor
Status: Needs review » Needs work

FeedsCommentProcessor shouln't extend FeedsNodeProcessor.

Feeds has this built in already.

  • twistor committed 1c7d2fc on 7.x-1.x 
    Issue #2016217 by jdillick, harings_rob, twistor: Per content type...
twistor’s picture

twistor commented
Assigned: twistor » Unassigned
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.