I believe that team members are meant to be comprised exclusively of members of the space that encloses the team (see attached screenshot from http://vimeo.com/64895874, which is from the developers demo #2). However it is possible to add users from the global user pool on the team page. When such a user attempts to access the team page they have been added to, access is denied (which is correct).
So I think two things need to get fixed:

  1. An autocomplete callback needs to be created that only returns members of the team's space, and its path needs to be substituted in oa_teams_add_team_member_form()
  2. oa_teams_add_team_member_form_validate() should check that the user is a member of the team's space
CommentFileSizeAuthor
Screen Shot 2013-06-07 at 3.36.57 PM.png121.82 KBpdcarto

Comments

mpotter’s picture

Status: Active » Fixed

This is already fixed in the latest -dev branch. When I create a Team I only see the users within the Space.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

paean99’s picture

Version: 7.x-2.0-alpha5 » 7.x-2.33
Issue summary: View changes
Status: Closed (fixed) » Active

I think that it isn't resolved in the team view page.
Given:

  • A space named SpaceA
  • A team named TeamA (with id: Xid) belonging to SpaceA

If you go to node/Xid/edit then the 'Members' widget on the right sidebar is working correctly.
But if you go to SpaceA/content/TeamA, the autocomplete of the 'Add Existing User' right sidebar widget gives every users on the system belonging or not to SpaceA.

If ones tries to add an user not belonging to the space, it gives an 'userX has been added to the team TeamA.' message, but the user doesn't appear anywhere on the team.
If ones tries to add again that same user it gives an 'User userX is already subscribed to group.' message.

edit: Although userX do not appear as a member of the team, it has same view access permissions to sections of SpaceA as the other members of TeamA, but not the edit permissions. Even when normal non-team member only get access denied messages.

paean99’s picture

Status: Active » Fixed

Since https://www.drupal.org/node/2463873 is probably the same issue and it was fixed in dev, i will mark as fixed this too.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.