drupal_container() is deprecated, and all calls in the shortcut module need to be replaced with Drupal::service(), except for where the module_handler service is requested, which needs to be replaced with Drupal::moduleHandler() (see #1957154)

This task a part of #2001206: Replace drupal_container() with Drupal::service()

Files: 
CommentFileSizeAuthor
#4 shortcut-2014011-4.patch3.62 KBkgoel
PASSED: [[SimpleTest]]: [MySQL] 57,460 pass(es).
[ View ]
#4 interdiff.txt1.3 KBkgoel
#2 shortcut-2014011-2.patch3.61 KBkgoel
FAILED: [[SimpleTest]]: [MySQL] 55,048 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

Comments

kgoel’s picture

Assigned:Unassigned» kgoel
kgoel’s picture

Status:Active» Needs review
StatusFileSize
new3.61 KB
FAILED: [[SimpleTest]]: [MySQL] 55,048 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

Status:Needs review» Needs work

The last submitted patch, shortcut-2014011-2.patch, failed testing.

kgoel’s picture

Status:Needs work» Needs review
StatusFileSize
new1.3 KB
new3.62 KB
PASSED: [[SimpleTest]]: [MySQL] 57,460 pass(es).
[ View ]
dcam’s picture

Status:Needs review» Reviewed & tested by the community

#4 looks good. All instances of drupal_container() in the shortcut module have been changed.

drupee’s picture

#4: shortcut-2014011-4.patch queued for re-testing.

webchick’s picture

Status:Reviewed & tested by the community» Fixed

Committed and pushed to 8.x. Thanks!

DmitryDrozdik’s picture

Status:Fixed» Closed (fixed)