drupal_container() is deprecated, and all calls in the serialization module need to be replaced with Drupal::service(), except for where the module_handler service is requested, which needs to be replaced with Drupal::moduleHandler() (see #1957154)

This task a part of #2001206: Replace drupal_container() with Drupal::service()

Files: 
CommentFileSizeAuthor
#6 serialization-2014009-6.patch626 byteskgoel
PASSED: [[SimpleTest]]: [MySQL] 57,155 pass(es). View
#5 serialization-2014009-5.patch633 byteskgoel
FAILED: [[SimpleTest]]: [MySQL] 55,176 pass(es), 1 fail(s), and 2 exception(s). View
#2 serialization-2014009-2.patch621 byteskgoel
FAILED: [[SimpleTest]]: [MySQL] 57,039 pass(es), 2 fail(s), and 0 exception(s). View

Comments

kgoel’s picture

Assigned:Unassigned» kgoel
kgoel’s picture

Status:Active» Needs review
StatusFileSize
new621 bytes
FAILED: [[SimpleTest]]: [MySQL] 57,039 pass(es), 2 fail(s), and 0 exception(s). View

Status:Needs review» Needs work

The last submitted patch, serialization-2014009-2.patch, failed testing.

ddrozdik’s picture

Please use $this->container->get() instead \Drupal::service in tests.

kgoel’s picture

Status:Needs work» Needs review
StatusFileSize
new633 bytes
FAILED: [[SimpleTest]]: [MySQL] 55,176 pass(es), 1 fail(s), and 2 exception(s). View
kgoel’s picture

StatusFileSize
new626 bytes
PASSED: [[SimpleTest]]: [MySQL] 57,155 pass(es). View
Crell’s picture

Status:Needs review» Reviewed & tested by the community
Issue tags:+Quick fix

Easy peasy.

alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed f7a22ec and pushed to 8.x. Thanks!

kgoel’s picture

Status:Fixed» Closed (fixed)