Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Use this for the testing the full patch - once we're green, we'll split them up though, see #1953408: Remove ArrayAccess BC layer from field config entities
Comment | File | Size | Author |
---|---|---|---|
#193 | drupal8.field-system.2013679-193.patch | 236.38 KB | andypost |
#190 | drupal8.field-system.2013679-190.patch | 233.34 KB | andypost |
#189 | interdiff.txt | 2.49 KB | andypost |
#187 | drupal8.field-system.2013679-187.patch | 238.23 KB | andypost |
#186 | interdiff.txt | 4.56 KB | andypost |
Comments
Comment #1
swentel CreditAttribution: swentel commentedLet's give this a first spin, this converts all the instances and I could install, so that's not that bad :)
Comment #3
swentel CreditAttribution: swentel commentedTssss
Comment #5
swentel CreditAttribution: swentel commentedShould fix installation (views related)
Comment #7
swentel CreditAttribution: swentel commented#5: 2013679-5.patch queued for re-testing.
Comment #9
swentel CreditAttribution: swentel commentedStupid image instance
Comment #11
swentel CreditAttribution: swentel commentedThis is with field arrayAccess gone as well, I could install and create fields (at least the body when creating a content type), let's see what the bot thinks.
Comment #13
swentel CreditAttribution: swentel commentedUrg
Comment #15
swentel CreditAttribution: swentel commentedComment #17
swentel CreditAttribution: swentel commentedComment #19
swentel CreditAttribution: swentel commentedShould have less exceptions and failures.
Comment #21
swentel CreditAttribution: swentel commentedKeeping up with head
Comment #23
swentel CreditAttribution: swentel commentedComment #25
swentel CreditAttribution: swentel commentedComment #27
swentel CreditAttribution: swentel commentedMore fixes, this is going to be a tedious one to get green :)
Comment #29
aspilicious CreditAttribution: aspilicious commentedComment #31
aspilicious CreditAttribution: aspilicious commentedHmm contained some merge conflicts
Comment #33
aspilicious CreditAttribution: aspilicious commentedSomething went wrong with merging. Please fix the issues in the sandbox if you want to. I need my sleep ;)
Comment #34
aspilicious CreditAttribution: aspilicious commentedLets see
Comment #36
aspilicious CreditAttribution: aspilicious commentedNot the expected results...
Comment #38
aspilicious CreditAttribution: aspilicious commentedAnd another one
Comment #40
aspilicious CreditAttribution: aspilicious commentedComment #42
aspilicious CreditAttribution: aspilicious commentedComment #44
aspilicious CreditAttribution: aspilicious commentedComment #45
aspilicious CreditAttribution: aspilicious commentedComment #46
aspilicious CreditAttribution: aspilicious commenteddamnit, goto patch creeped in
Comment #47
aspilicious CreditAttribution: aspilicious commentedComment #49
aspilicious CreditAttribution: aspilicious commentedLets try something
Comment #51
aspilicious CreditAttribution: aspilicious commentedComment #53
aspilicious CreditAttribution: aspilicious commentedComment #55
aspilicious CreditAttribution: aspilicious commentedComment #57
aspilicious CreditAttribution: aspilicious commentedComment #58
aspilicious CreditAttribution: aspilicious commentedComment #59
aspilicious CreditAttribution: aspilicious commentedComment #60
aspilicious CreditAttribution: aspilicious commentedComment #61
aspilicious CreditAttribution: aspilicious commentedComment #62
aspilicious CreditAttribution: aspilicious commentedThis one should help alot as it fixes the field UI :p
Comment #64
aspilicious CreditAttribution: aspilicious commented#62: 2013679-62.patch queued for re-testing.
Comment #65
aspilicious CreditAttribution: aspilicious commentedMore fixes!
Comment #67
aspilicious CreditAttribution: aspilicious commentedComment #68
aspilicious CreditAttribution: aspilicious commentedComment #69
aspilicious CreditAttribution: aspilicious commentedDeletion of fields was broken in the ui. Fixed.
Comment #70
aspilicious CreditAttribution: aspilicious commentedEntity reference related fixes
Comment #71
aspilicious CreditAttribution: aspilicious commentedComment #73
aspilicious CreditAttribution: aspilicious commentedComment #75
aspilicious CreditAttribution: aspilicious commentedComment #77
aspilicious CreditAttribution: aspilicious commentedComment #78
aspilicious CreditAttribution: aspilicious commentedComment #80
aspilicious CreditAttribution: aspilicious commented#78: 2013679-78.patch queued for re-testing.
Comment #81
aspilicious CreditAttribution: aspilicious commentedComment #82
aspilicious CreditAttribution: aspilicious commentedComment #83
aspilicious CreditAttribution: aspilicious commentedComment #85
aspilicious CreditAttribution: aspilicious commentedComment #87
swentel CreditAttribution: swentel commentedShould fix mosts tests except for first two.
Comment #89
swentel CreditAttribution: swentel commentedKickstarting again, merge was ridiculous, so we'll have todo work again I'm afraid - although the field interface might slim it down though.
Let's see what this gives ...
Comment #91
swentel CreditAttribution: swentel commentedGo installation
Comment #93
swentel CreditAttribution: swentel commentedGo login
Comment #95
swentel CreditAttribution: swentel commentedMore obvious fixes.
Comment #97
swentel CreditAttribution: swentel commentedMore fixes, but still trying to kill the exceptions.
Comment #98
swentel CreditAttribution: swentel commentedActually, bad merge due to git, damn!
Comment #100
swentel CreditAttribution: swentel commentedComment #102
Berdir#100: 2013679-100.patch queued for re-testing.
Comment #104
swentel CreditAttribution: swentel commentedComment #106
swentel CreditAttribution: swentel commentedBah, uploaded wrong patch
Comment #108
swentel CreditAttribution: swentel commentedComment #110
swentel CreditAttribution: swentel commentedComment #112
aspilicious CreditAttribution: aspilicious commentedCould be green :)
Comment #113
aspilicious CreditAttribution: aspilicious commentedbtw unrelated changes sneaked in...
core/modules/field_ui/field_ui.admin.inc and some other file
Comment #114
swentel CreditAttribution: swentel commentedhmm that file doesn't even exist anymore in head, so we should ditch that one
Comment #115
BerdirI think field_name should always be changed to getFieldName(), id() will change in the entity storage issue.
Comment #116
swentel CreditAttribution: swentel commentedJust another run to keep up with head, one test will definitely fail as I merged wrong. Want to see if others are affected too.
Comment #118
swentel CreditAttribution: swentel commentedComment #120
swentel CreditAttribution: swentel commentedMerged with core + last test fix, will start addressing #115 from now on too.
Comment #122
swentel CreditAttribution: swentel commentedboo swentel, boo!
Comment #123
swentel CreditAttribution: swentel commentedChasing HEAD (will contain test failures though due to bad merge)
Comment #125
aspilicious CreditAttribution: aspilicious commentedFatal error: Cannot use object of type Drupal\field\Entity\Field as array in /var/lib/drupaltestbot/sites/default/files/checkout/core/lib/Drupal/Core/Entity/Query/Sql/Tables.php on line 118
Fatal error: Cannot use object of type Drupal\field\Entity\Field as array in /var/lib/drupaltestbot/sites/default/files/checkout/core/modules/entity_reference/lib/Drupal/entity_reference/Plugin/field/field_type/ConfigurableEntityReferenceItem.php on line 71
Fatal error: Cannot use object of type Drupal\field\Entity\FieldInstance as array in /var/lib/drupaltestbot/sites/default/files/checkout/core/modules/node/lib/Drupal/node/Tests/NodeTokenReplaceTest.php on line 57
Fix these and create a new patch. Will fix most of the issues I think.
Comment #126
swentel CreditAttribution: swentel commentedComment #128
swentel CreditAttribution: swentel commentedComment #130
aspilicious CreditAttribution: aspilicious commentedThis is a terrible job :(
Comment #132
aspilicious CreditAttribution: aspilicious commentedARGH!
Comment #134
swentel CreditAttribution: swentel commentedLogin at least works again, expect much failures, will work on this all day.
Comment #136
swentel CreditAttribution: swentel commentedComment #138
swentel CreditAttribution: swentel commentedComment #140
swentel CreditAttribution: swentel commentedComment #142
swentel CreditAttribution: swentel commentedSimple fix for a lot of fixes, digging further in others
Comment #144
swentel CreditAttribution: swentel commentedComment #145
aspilicious CreditAttribution: aspilicious commentedContains more fixes
Comment #147
aspilicious CreditAttribution: aspilicious commented< 200 fails hopefully
Comment #148
aspilicious CreditAttribution: aspilicious commentedgo!
Comment #150
aspilicious CreditAttribution: aspilicious commented< 100 ? Go!
Comment #151
aspilicious CreditAttribution: aspilicious commentedWhile grepping for some stuff I came around field_test.storage.inc I think it needs some work...
Comment #152
aspilicious CreditAttribution: aspilicious commentedLast one for today
Comment #153
Berdir@aspilicious: field_test.storage.inc is dead code, can be removed completely. The API that it provides a test implementation for no longer exists. Not here, of course :)
Comment #155
swentel CreditAttribution: swentel commentedMore fixes.
Comment #157
swentel CreditAttribution: swentel commentedthis might be green
Comment #159
swentel CreditAttribution: swentel commentedRemoved some obsolete files that were still in our sandbox
Comment #161
swentel CreditAttribution: swentel commentedI'm kind of lost with the failure in FieldAttachOtherTest. I've been looking at the entity storage patch as well and it makes some weird changes. @yched in case you could have closer look, because I can't see what the hell can go wrong.
Comment #162
swentel CreditAttribution: swentel commentedFix file field validation, damn, PHP is so dumb.
Hopefully, the forum merge didn't break anything.
FieldAttachOtherTest is the last remaining.
Comment #164
aspilicious CreditAttribution: aspilicious commentedI hope this one will apply, used methods in stead of direct property access
Comment #166
aspilicious CreditAttribution: aspilicious commentedSecond try
Comment #168
aspilicious CreditAttribution: aspilicious commentedmèèh
Comment #169
aspilicious CreditAttribution: aspilicious commentedAnother try, tested this one. Site loads again...
Comment #171
aspilicious CreditAttribution: aspilicious commentedSIGH!
We can't do
empty($instance->getFieldSetting('translation_sync'))
So this needs more work :(
tomorow...
Comment #172
yched CreditAttribution: yched commentedRegarding the field cache fails:
@plach's #1983554-28: Remove BC-mode from EntityNG might be related ?
Comment #173
aspilicious CreditAttribution: aspilicious commentedOk not sure if this is going to work...
Comment #175
aspilicious CreditAttribution: aspilicious commented.
Comment #177
aspilicious CreditAttribution: aspilicious commentedComment #178
aspilicious CreditAttribution: aspilicious commentedComment #180
aspilicious CreditAttribution: aspilicious commentedTested this one a bit better
Comment #182
aspilicious CreditAttribution: aspilicious commentedComment #184
aspilicious CreditAttribution: aspilicious commentedLess fails.
I broke image handling somewhere but I can't find it.
FieldInfoTest fail is stupid field'settings'] returns something different than getFieldSettings()
Comment #186
andypostShould be green now! all pushed
Test
FieldAttachOtherTest
probably needs follow-up for core, because actually broken now (string offset used as cardinality so no items are generatedImageFormatterBase fix seems breaks a scope a bit but it's needed to fix test
Comment #187
andypostmerged head
Comment #189
andypostalso reverted a part and files patch to main issue #1953408-30: Remove ArrayAccess BC layer from field config entities
Comment #190
andypostmerge
Comment #191
andypostComment #193
andypostFix install via DatabaseStorageController.php and
clean-up TranslatableForm.php - use direct property for equality (related fix #1946462: Convert content_translation_translatable_form() to the new form interface
Comment #194
swentel CreditAttribution: swentel commentedWe're close on the other one, so closing this one.