Protocol is not considered in the caching logic

Hello

As a consequence of this core problem (https://drupal.org/node/1377840), Scald is not using the protocol in his caching logic so we can run into following situations :

- If you don't have a valid ssl cert, the cached item was generated under ssl by someone, and a visitor hits a non-ssl version of the page the item included will not be displayed because the invalid cert has not been accepted.
- If a cached item was generated on a non-ssl page and is then displayed in an ssl page a ssl error will be displayed for including non-ssl assets in the page.

Could it be possible to include in Scald core the protocol as an additional caching key ?

One quick and dirty workaround could be to write in a custom player something like this :

$atom->rendered->thumbnail_transcoded_url = preg_replace('#^https?:#',
'', $atom->rendered->thumbnail_transcoded_url);

But it would be probably better to built this kind stuff in the core.

Thanks for the feedback...