drupal_container() is deprecated, and all calls in the path module need to be replaced with Drupal::service(), except for where the module_handler service is requested, which needs to be replaced with Drupal::moduleHandler() (see #1957154: Replace calls to drupal_container()->get('module_handler') service with Drupal::moduleHandler())

Files: 
CommentFileSizeAuthor
#4 path-2011116-4.patch7.42 KBkgoel
PASSED: [[SimpleTest]]: [MySQL] 57,224 pass(es). View
#4 interdiff.txt3.16 KBkgoel
#2 path-2011116-2.patch7.39 KBkgoel
PASSED: [[SimpleTest]]: [MySQL] 55,717 pass(es). View

Comments

kgoel’s picture

Assigned: Unassigned » kgoel
kgoel’s picture

Status: Active » Needs review
FileSize
7.39 KB
PASSED: [[SimpleTest]]: [MySQL] 55,717 pass(es). View
dcam’s picture

Status: Needs review » Needs work

It looks like there are a lot of calls in PathAliasTest.php that need to be converted to this->container->get().

kgoel’s picture

Status: Needs work » Needs review
FileSize
3.16 KB
7.42 KB
PASSED: [[SimpleTest]]: [MySQL] 57,224 pass(es). View
dcam’s picture

Status: Needs review » Reviewed & tested by the community

#4 looks good. The patch converts all uses of drupal_container() in the path module.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

ddrozdik’s picture

Status: Fixed » Closed (fixed)