Problem/Motivation

Open any admin page without overlay mode & scrool page down. You will see some transparent area in tray.

Proposed resolution

Apply white background to parent element.

fixed bug.jpg

CommentFileSizeAuthor
#13 toolbar.module-fix_tray_transparency-2010284-13.patch388 bytesMiroling
#7 toolbar.module-fix_tray_transparency-2010284-2.patch399 bytesMiroling
#5 view-edit.png5.6 KBandypost
#5 view-list.png7.2 KBandypost
fixed bug.jpg24.75 KBMiroling

Comments

Miroling’s picture

Miroling commented

Sorry, I'm novice here so can't post path file "toolbar.module-fix_tray_transparency-2010284-2.path" as needed & placed code as is.

diff --git a/core/modules/toolbar/css/toolbar.theme.css b/core/modules/toolbar/css/toolbar.theme.css
index 4120135..4b1805f 100644
--- a/core/modules/toolbar/css/toolbar.theme.css
+++ b/core/modules/toolbar/css/toolbar.theme.css
@@ -50,7 +50,7 @@
 /**
  * Toolbar tray.
  */
-.toolbar .tray > .lining {
+.toolbar .tray {
   background-color: #ffffff;
 }
 .toolbar .horizontal > .lining {
Miroling’s picture

Miroling commented
Issue tags: +CodeSprintUA

Added sprint tag

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Needs work
Issue tags: +Needs manual testing

Please point a browser + version where you get this error

Miroling’s picture

Miroling commented

Please, try to open /admin/structure/views without overlay at any browser

  • Google chrome 27.0.1453.94 m
  • Internet Explorer 10.0.5
  • Mozila Firefox 21
  • Opera 12.15

Commit 6049d2517d19a5ce8d0685dca489dba6ec764341

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Needs review
StatusFileSize
new view-list.png7.2 KB
new view-edit.png5.6 KB

Thanx a lot, I can confirm that area in toolbar is transparent for view listing and view edit!

Miroling, please put #1 into file with .patch extension
view-edit.png

view-list.png

andypost’s picture

andypost
he/him
Primary language Russian
commented

Also I confirm that #1 fixes the transparency

Miroling’s picture

Miroling commented
StatusFileSize
new toolbar.module-fix_tray_transparency-2010284-2.patch399 bytes

Patch for issue fixing

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Status: Needs review » Reviewed & tested by the community

#7 looks good for me

andypost’s picture

andypost
he/him
Primary language Russian
commented

+1 to RTBC

Miroling’s picture

Miroling commented

Thx guys for nice feedback. This simple fix great step for me.

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Issue tags: -Needs manual testing

removing tag

Status: Reviewed & tested by the community » Needs work

The last submitted patch, toolbar.module-fix_tray_transparency-2010284-2.patch, failed testing.

Miroling’s picture

Miroling commented
StatusFileSize
new toolbar.module-fix_tray_transparency-2010284-13.patch388 bytes
Miroling’s picture

Miroling commented
Status: Needs work » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 5169589 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.