Part of #2010184: [meta] convert ‘uri_callback’ entities param to EntityInterface::uri() method.

Needs to implement Plugin\Entity\PictureMapping.php uri() method and drop picture_mapping_uri() function replacing it's calls to $entity->uri() and clean-up uri_callback at entity annotation.

CommentFileSizeAuthor
#5 convert-picture-mapping-uri-2010216-5.patch1.67 KBhussainweb
#3 convert-picture-mapping-uri-2010216-3.patch1.68 KBkgoel
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

InternetDevels’s picture

InternetDevels CreditAttribution: InternetDevels commented
Assigned: InternetDevels » Unassigned
kgoel’s picture

kgoel CreditAttribution: kgoel commented
Assigned: Unassigned » kgoel

Going to work on this.

kgoel’s picture

kgoel CreditAttribution: kgoel commented
Status: Active » Needs review
FileSize
convert-picture-mapping-uri-2010216-3.patch1.68 KB
tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented
Status: Needs review » Needs work 
+++ b/core/modules/picture/lib/Drupal/picture/Plugin/Core/Entity/PictureMapping.php
@@ -161,5 +160,17 @@ public function hasMappings() {
+  ¶

Trailing whitespace. Otherwise, looks great!

hussainweb’s picture

hussainweb
Primary language English
CreditAttribution: hussainweb commented
FileSize
convert-picture-mapping-uri-2010216-5.patch1.67 KB

Fixing whitespace.

hussainweb’s picture

hussainweb
Primary language English
CreditAttribution: hussainweb commented
Status: Needs work » Needs review
tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented
Status: Needs review » Reviewed & tested by the community

Awesome!

To be extra sure I grepped for picture_mapping_set_uri, but there's nothing there...

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 33bee3c and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.

Eli-T’s picture

Eli-T
he/him
Primary language English
Location Manchester
CreditAttribution: Eli-T commented
Component: picture.module » responsive_image.module
Issue summary: View changes